Replace find bar RequestFocus override with OnFocus.

Replace find bar RequestFocus override with OnFocus.

Make View::RequestFocus non-virtual; replace override.
Also add mouse-press/release inhibiting of select-all.
(this prevents a flash of all text selected on click)

BUG=232290
TEST=No find bar focus-related behavior/appearance regressions; switching back to a tab that had the find bar focused (from a tab that didn't have the find bar focused) restores find bar focus and selects the entire text content; clicking the find bar doesn't flash all the text selected before placing the cursor or starting a drag.
R=ben@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195028

[msw, 2013-04-18 19:16:11]

Hey Ben, please take a look; thanks!

[Ben Goodger (Google), 2013-04-18 19:38:51]

https://codereview.chromium.org/13852009/diff/4001/chrome/browser/ui/views/fi...
File chrome/browser/ui/views/find_bar_view.cc (right):

https://codereview.chromium.org/13852009/diff/4001/chrome/browser/ui/views/fi...
chrome/browser/ui/views/find_bar_view.cc:508: select_all_on_focus_ = false;
can you explain in more detail why this is needed? Is OnFocus() being called
even when the View is already focused?

[msw, 2013-04-18 20:07:25]

Please take another look; thanks!

https://codereview.chromium.org/13852009/diff/4001/chrome/browser/ui/views/fi...
File chrome/browser/ui/views/find_bar_view.cc (right):

https://codereview.chromium.org/13852009/diff/4001/chrome/browser/ui/views/fi...
chrome/browser/ui/views/find_bar_view.cc:508: select_all_on_focus_ = false;
On 2013/04/18 19:38:51, Ben Goodger (Google) wrote:
> can you explain in more detail why this is needed? Is OnFocus() being called
> even when the View is already focused?

Oh, no. It's only needed for when the view is gaining focus from a click, which
should set the cursor position or let the user start a drag (and it already
does) but it shouldn't flicker all the text being selected on that initial mouse
down to focus the textfield before setting the cursor or starting a drag (this
flag prevents that). I added a clarifying comment.

[Ben Goodger (Google), 2013-04-18 20:16:01]

your cl is busted

[msw, 2013-04-18 20:24:10]

On 2013/04/18 20:16:01, Ben Goodger (Google) wrote:
> your cl is busted

Sorry :( What's busted, more specifically? It works fine locally on ToT 
non-Aura Win, does it misbehave on Aura or CrOS?

[msw, 2013-04-18 20:26:02]

On 2013/04/18 20:24:10, msw wrote:
> On 2013/04/18 20:16:01, Ben Goodger (Google) wrote:
> > your cl is busted
> 
> Sorry :( What's busted, more specifically? It works fine locally on ToT 
> non-Aura Win, does it misbehave on Aura or CrOS?

Oh! Literally, the upload/diffing failed! Sorry, check now.

[Ben Goodger (Google), 2013-04-18 20:36:32]

lgtm

[commit-bot: I haz the power, 2013-04-18 20:42:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/13852009/19001

[commit-bot: I haz the power, 2013-04-19 00:48:21]

Change committed as 195028