Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Unified Diff: chrome/browser/ui/views/find_bar_view.h

Issue 13852009: Replace find bar RequestFocus override with OnFocus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a comment about select_all_on_focus_. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/find_bar_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/find_bar_view.h
diff --git a/chrome/browser/ui/views/find_bar_view.h b/chrome/browser/ui/views/find_bar_view.h
index 7f3e89928ab1b2e520e02c97ac67bd28d2954a6f..d4cdfa003810b09204416e0247337821b35f14e3 100644
--- a/chrome/browser/ui/views/find_bar_view.h
+++ b/chrome/browser/ui/views/find_bar_view.h
@@ -87,7 +87,7 @@ class FindBarView : public DropdownBarView,
// Update the appearance for the match count label.
void UpdateMatchCountAppearance(bool no_match);
- // Overridden from views::View.
+ // views::View:
virtual void OnThemeChanged() OVERRIDE;
// We use a hidden view to grab mouse clicks and bring focus to the find
@@ -117,9 +117,16 @@ class FindBarView : public DropdownBarView,
SearchTextfieldView();
virtual ~SearchTextfieldView();
- virtual void RequestFocus() OVERRIDE;
+ // views::View:
+ virtual bool OnMousePressed(const ui::MouseEvent& event) OVERRIDE;
+ virtual void OnMouseReleased(const ui::MouseEvent& event) OVERRIDE;
+
+ // views::Textfield:
+ virtual void OnFocus() OVERRIDE;
private:
+ bool select_all_on_focus_;
+
DISALLOW_COPY_AND_ASSIGN(SearchTextfieldView);
};
« no previous file with comments | « no previous file | chrome/browser/ui/views/find_bar_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698