Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 13852008: Removing redundant collection methods from DOM collections. (Closed)

Created:
7 years, 8 months ago by blois
Modified:
7 years, 8 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

With the collections deriving from ListBase, we no longer need to implement a number of boiler-plate methods. There are some gotchas with Element and Node lists as they may mutate the list being passed in if it's a nodelist as well, so I'm keeping those unimplemented. In some cases this may fall back to less efficient operations (such as the WrappedList which no longer forwards every method), but I tried to keep all of the primary cases fast and I believe that these methods would fall back to generic implementations anyways in all cases where we use the classes. BUG= Committed: https://code.google.com/p/dart/source/detail?r=21848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+154 lines, -1090 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 16 chunks +16 lines, -333 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 16 chunks +16 lines, -333 lines 0 comments Download
M sdk/lib/html/html_common/filtered_element_list.dart View 4 chunks +5 lines, -84 lines 0 comments Download
M tests/html/element_test.dart View 4 chunks +39 lines, -7 lines 0 comments Download
M tests/html/node_test.dart View 2 chunks +62 lines, -0 lines 0 comments Download
M tools/dom/src/WrappedList.dart View 5 chunks +1 line, -83 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 9 chunks +7 lines, -212 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 2 chunks +8 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 8 months ago (2013-04-18 17:45:23 UTC) #1
sra1
lgtm
7 years, 8 months ago (2013-04-19 20:51:19 UTC) #2
blois
7 years, 8 months ago (2013-04-22 22:29:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21848 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698