Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6685)

Unified Diff: chrome/renderer/extensions/extension_localization_peer_unittest.cc

Issue 138513002: Plumb network stack information about existence of cached copy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated comments from Matt & Ricardo. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_localization_peer_unittest.cc
diff --git a/chrome/renderer/extensions/extension_localization_peer_unittest.cc b/chrome/renderer/extensions/extension_localization_peer_unittest.cc
index d0a1ed4de5d49dab4ba33fefb2d7f9b54df909bf..e110030672de9ad5c306cb87c7ef2a286f0ad5b9 100644
--- a/chrome/renderer/extensions/extension_localization_peer_unittest.cc
+++ b/chrome/renderer/extensions/extension_localization_peer_unittest.cc
@@ -68,9 +68,10 @@ class MockResourceLoaderBridgePeer
MOCK_METHOD3(OnReceivedData, void(const char* data,
int data_length,
int encoded_data_length));
- MOCK_METHOD4(OnCompletedRequest, void(
+ MOCK_METHOD5(OnCompletedRequest, void(
int error_code,
bool was_ignored_by_handler,
+ bool stale_copy_in_cache,
const std::string& security_info,
const base::TimeTicks& completion_time));
@@ -142,10 +143,10 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestBadURLRequestStatus) {
EXPECT_CALL(*original_peer_, OnReceivedResponse(_));
EXPECT_CALL(*original_peer_, OnCompletedRequest(
- net::ERR_ABORTED, false, "", base::TimeTicks()));
+ net::ERR_ABORTED, false, false, "", base::TimeTicks()));
filter_peer->OnCompletedRequest(
- net::ERR_FAILED, false, std::string(), base::TimeTicks());
+ net::ERR_FAILED, false, false, std::string(), base::TimeTicks());
}
TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestEmptyData) {
@@ -157,10 +158,10 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestEmptyData) {
EXPECT_CALL(*original_peer_, OnReceivedResponse(_));
EXPECT_CALL(*original_peer_, OnCompletedRequest(
- net::OK, false, "", base::TimeTicks()));
+ net::OK, false, false, "", base::TimeTicks()));
filter_peer->OnCompletedRequest(
- net::OK, false, std::string(), base::TimeTicks());
+ net::OK, false, false, std::string(), base::TimeTicks());
}
TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestNoCatalogs) {
@@ -177,10 +178,10 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestNoCatalogs) {
EXPECT_CALL(*original_peer_, OnReceivedResponse(_)).Times(2);
EXPECT_CALL(*original_peer_, OnCompletedRequest(
- net::OK, false, "", base::TimeTicks())).Times(2);
+ net::OK, false, false, "", base::TimeTicks())).Times(2);
filter_peer->OnCompletedRequest(
- net::OK, false, std::string(), base::TimeTicks());
+ net::OK, false, false, std::string(), base::TimeTicks());
// Test if Send gets called again (it shouldn't be) when first call returned
// an empty dictionary.
@@ -188,7 +189,7 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestNoCatalogs) {
CreateExtensionLocalizationPeer("text/css", GURL(kExtensionUrl_1));
SetData(filter_peer, "some text");
filter_peer->OnCompletedRequest(
- net::OK, false, std::string(), base::TimeTicks());
+ net::OK, false, false, std::string(), base::TimeTicks());
}
TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestWithCatalogs) {
@@ -214,10 +215,10 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestWithCatalogs) {
EXPECT_CALL(*original_peer_, OnReceivedResponse(_));
EXPECT_CALL(*original_peer_, OnCompletedRequest(
- net::OK, false, "", base::TimeTicks()));
+ net::OK, false, false, "", base::TimeTicks()));
filter_peer->OnCompletedRequest(
- net::OK, false, std::string(), base::TimeTicks());
+ net::OK, false, false, std::string(), base::TimeTicks());
}
TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestReplaceMessagesFails) {
@@ -243,8 +244,8 @@ TEST_F(ExtensionLocalizationPeerTest, OnCompletedRequestReplaceMessagesFails) {
EXPECT_CALL(*original_peer_, OnReceivedResponse(_));
EXPECT_CALL(*original_peer_, OnCompletedRequest(
- net::OK, false, "", base::TimeTicks()));
+ net::OK, false, false, "", base::TimeTicks()));
filter_peer->OnCompletedRequest(
- net::OK, false, std::string(), base::TimeTicks());
+ net::OK, false, false, std::string(), base::TimeTicks());
}

Powered by Google App Engine
This is Rietveld 408576698