chrome/common/localized_error.cc - Issue 138513002: Plumb network stack information about existence of cached copy

Unified Diff: chrome/common/localized_error.cc

Issue 138513002: Plumb network stack information about existence of cached copy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated comments from Matt & Ricardo. Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/localized_error.cc

diff --git a/chrome/common/localized_error.cc b/chrome/common/localized_error.cc

index d85428cb382c5ef3d37189afc80d2eee442bfbc4..129618d54900b182cc586beb2ac69782900ff0cd 100644

--- a/chrome/common/localized_error.cc

+++ b/chrome/common/localized_error.cc

@@ -494,6 +494,7 @@ void LocalizedError::GetStrings(int error_code,

const std::string& error_domain,

const GURL& failed_url,

bool is_post,

+ bool stale_copy_in_cache,

const std::string& locale,

const std::string& accept_languages,

base::DictionaryValue* error_strings) {

@@ -558,6 +559,8 @@ void LocalizedError::GetStrings(int error_code,

error_strings->SetString(

"less", l10n_util::GetStringUTF16(IDS_ERRORPAGES_BUTTON_LESS));

error_strings->Set("summary", summary);

+ error_strings->SetBoolean("staleCopyInCache", stale_copy_in_cache);

mmenke 2014/01/28 17:27:23 From a UI consistency standpoint, may want to add

mmenke 2014/01/28 17:27:23 Just a heads up that we may want to, at least temp

Randy Smith (Not in Mondays) 2014/01/28 22:52:59 As discussed offline, ignoring for now.

Randy Smith (Not in Mondays) 2014/01/28 22:52:59 Based on our discussion, I think this is moot.

#if defined(OS_CHROMEOS)

error_strings->SetString(

"diagnose", l10n_util::GetStringUTF16(IDS_ERRORPAGES_BUTTON_DIAGNOSE));