Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1385113002: MD Downloads: a step toward better RTL support (Closed)

Created:
5 years, 2 months ago by Dan Beam
Modified:
5 years, 2 months ago
Reviewers:
tommycli
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: a step toward better RTL support There are still other issues, but the menu should at least open in the correct direction in RTL. R=tommycli@chromium.org BUG=538245 Committed: https://crrev.com/598d30bf768fe5dfee693660e56c3106a8b03af2 Cr-Commit-Position: refs/heads/master@{#352651}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M chrome/browser/resources/md_downloads/crisper.js View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.js View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Beam
note: crisper.js and vulcanize.html are generated
5 years, 2 months ago (2015-10-06 01:30:14 UTC) #2
tommycli
lgtm
5 years, 2 months ago (2015-10-06 17:44:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385113002/1
5 years, 2 months ago (2015-10-06 17:47:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 18:49:07 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 18:49:57 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/598d30bf768fe5dfee693660e56c3106a8b03af2
Cr-Commit-Position: refs/heads/master@{#352651}

Powered by Google App Engine
This is Rietveld 408576698