chrome/browser/resources/md_downloads/toolbar.js - Issue 1385113002: MD Downloads: a step toward better RTL support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_downloads/toolbar.js

Issue 1385113002: MD Downloads: a step toward better RTL support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/md_downloads/toolbar.js

diff --git a/chrome/browser/resources/md_downloads/toolbar.js b/chrome/browser/resources/md_downloads/toolbar.js

index 4827868e6807229ef4c134a2798986358e71973f..f9437c02b2bdd1dd054b1ab78333e44828d16363 100644

--- a/chrome/browser/resources/md_downloads/toolbar.js

+++ b/chrome/browser/resources/md_downloads/toolbar.js

@@ -7,6 +7,9 @@ cr.define('downloads', function() {

is: 'downloads-toolbar',

attached: function() {

+ // isRTL() only works after i18n_template.js runs to set <html dir>.

+ this.overflowAlign_ = isRTL() ? 'left' : 'right';

/** @private {!SearchFieldDelegate} */

this.searchFieldDelegate_ = new ToolbarSearchFieldDelegate(this);

this.$['search-input'].setDelegate(this.searchFieldDelegate_);

@@ -19,6 +22,11 @@ cr.define('downloads', function() {

value: false,

observer: 'onDownloadsShowingChange_',

+ overflowAlign_: {

+ type: String,

+ value: 'right',

+ },

/** @return {boolean} Whether removal can be undone. */