Remove ChromeClient cruft

Source/WebKit/chromium/src/ChromeClientImpl.cpp

Index: Source/WebKit/chromium/src/ChromeClientImpl.cpp
diff --git a/Source/WebKit/chromium/src/ChromeClientImpl.cpp b/Source/WebKit/chromium/src/ChromeClientImpl.cpp
index f2051dd2be35609bb69190d91e81ce174f6f6109..ba2c4199d5d9961a46c938d89634f4292548c6ab 100644
--- a/Source/WebKit/chromium/src/ChromeClientImpl.cpp
+++ b/Source/WebKit/chromium/src/ChromeClientImpl.cpp
@@ -240,10 +240,6 @@ void ChromeClientImpl::focusedNodeChanged(Node* node)
     m_webView->client()->setKeyboardFocusURL(focusURL);
 }
 
-void ChromeClientImpl::focusedFrameChanged(Frame*)
-{
-}
-
 Page* ChromeClientImpl::createWindow(
     Frame* frame, const FrameLoadRequest& r, const WindowFeatures& features, const NavigationAction& action)
 {
@@ -479,12 +475,6 @@ void ChromeClientImpl::setStatusbarText(const String& message)
         m_webView->client()->setStatusText(message);
 }
 
-bool ChromeClientImpl::shouldInterruptJavaScript()
-{
-    // FIXME: implement me
-    return false;
-}
-
 KeyboardUIMode ChromeClientImpl::keyboardUIMode()
 {
     return m_webView->tabsToLinks() ? KeyboardAccessTabsToLinks : KeyboardAccessDefault;
@@ -498,11 +488,6 @@ IntRect ChromeClientImpl::windowResizerRect() const
     return result;
 }
 
-void ChromeClientImpl::invalidateRootView(const IntRect&)
-{
-    notImplemented();
-}
-
 void ChromeClientImpl::invalidateContentsAndRootView(const IntRect& updateRect)
 {
     if (updateRect.isEmpty())
@@ -705,21 +690,6 @@ void ChromeClientImpl::print(Frame* frame)
         m_webView->client()->printPage(WebFrameImpl::fromFrame(frame));
 }
 
-void ChromeClientImpl::exceededDatabaseQuota(Frame* frame, const String& databaseName, DatabaseDetails)
-{
-    // Chromium users cannot currently change the default quota
-}
-
-void ChromeClientImpl::reachedMaxAppCacheSize(int64_t spaceNeeded)
-{
-    ASSERT_NOT_REACHED();
-}
-
-void ChromeClientImpl::reachedApplicationCacheOriginQuota(SecurityOrigin*, int64_t)
-{
-    ASSERT_NOT_REACHED();
-}
-
 #if ENABLE(INPUT_TYPE_COLOR)
 PassOwnPtr<ColorChooser> ChromeClientImpl::createColorChooser(ColorChooserClient* chooserClient, const Color&)
 {
@@ -991,11 +961,6 @@ ChromeClient::CompositingTriggerFlags ChromeClientImpl::allowedCompositingTrigge
     return flags;
 }
 
-bool ChromeClientImpl::supportsFullscreenForNode(const Node* node)
-{
-    return false;
-}
-
 void ChromeClientImpl::enterFullscreenForNode(Node* node)

[adamk, 2013/04/30 00:05:07]

Actually, while I've got you here: can I remove these too? The
ASSERT_NOT_REACHED suggests yes, but the code in HTMLMediaElement seems like it
could call it...

[darin (slow to review), 2013/04/30 03:47:46]

Yes, this is all code for the old way of doing fullscreen for only the <video>
element.  We now just use the general purpose fullscreen code.  Some WebKit
ports were still shipping the old API IIRC.

[adamk, 2013/04/30 16:45:03]

I'll take care of this in a followup deleting all the old codepath (which
includes non-chromeclient stuff in HTMLMediaElement)

 {
     ASSERT_NOT_REACHED();
@@ -1006,11 +971,6 @@ void ChromeClientImpl::exitFullscreenForNode(Node* node)
     ASSERT_NOT_REACHED();
 }
 
-bool ChromeClientImpl::supportsFullScreenForElement(const Element* element, bool withKeyboard)
-{
-    return true;
-}
-
 void ChromeClientImpl::enterFullScreenForElement(Element* element)
 {
     m_webView->enterFullScreenForElement(element);
@@ -1021,21 +981,6 @@ void ChromeClientImpl::exitFullScreenForElement(Element* element)
     m_webView->exitFullScreenForElement(element);
 }
 
-void ChromeClientImpl::fullScreenRendererChanged(RenderBox*)
-{
-    notImplemented();
-}
-
-bool ChromeClientImpl::selectItemWritingDirectionIsNatural()
-{
-    return false;
-}
-
-bool ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection()
-{
-    return true;
-}
-
 bool ChromeClientImpl::hasOpenedPopup() const
 {
     return m_webView->hasOpenedPopup();
@@ -1140,12 +1085,6 @@ void ChromeClientImpl::numWheelEventHandlersChanged(unsigned numberOfWheelHandle
     m_webView->numberOfWheelEventHandlersChanged(numberOfWheelHandlers);
 }
 
-bool ChromeClientImpl::shouldAutoscrollForDragAndDrop(WebCore::RenderBox*) const
-{
-    return true;
-}
-
-
 void ChromeClientImpl::needTouchEvents(bool needsTouchEvents)
 {
     m_webView->hasTouchEventHandlers(needsTouchEvents);
@@ -1184,11 +1123,6 @@ void ChromeClientImpl::didAssociateFormControls(const Vector<RefPtr<Element> >&
     m_webView->autofillClient()->didAssociateFormControls(elementVector);
 }
 
-bool ChromeClientImpl::shouldNotifyOnFormChanges()
-{
-    return true;
-}
-
 #if ENABLE(NAVIGATOR_CONTENT_UTILS)
 PassOwnPtr<NavigatorContentUtilsClientImpl> NavigatorContentUtilsClientImpl::create(WebViewImpl* webView)
 {