Remove ChromeClient cruft

Source/WebKit/chromium/src/ChromeClientImpl.cpp

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 222 matching lines @@
         // WebCore::Node.
         HitTestResult hitTest(IntPoint(0, 0));
         // This cast must be valid because of the isLink() check.
         hitTest.setURLElement(toElement(node));
         if (hitTest.isLiveLink())
             focusURL = hitTest.absoluteLinkURL();
     }
     m_webView->client()->setKeyboardFocusURL(focusURL);
 }
 
-void ChromeClientImpl::focusedFrameChanged(Frame*)
-{
-}
-
 Page* ChromeClientImpl::createWindow(
     Frame* frame, const FrameLoadRequest& r, const WindowFeatures& features, const NavigationAction& action)
 {
     if (!m_webView->client())
         return 0;
 
     // FrameLoaderClientImpl may have given us a policy to use for the next new
     // window navigation. If not, determine the policy using the same logic as
     // show().
     WebNavigationPolicy policy;
@@ skipping 215 matching lines @@
     }
     return false;
 }
 
 void ChromeClientImpl::setStatusbarText(const String& message)
 {
     if (m_webView->client())
         m_webView->client()->setStatusText(message);
 }
 
-bool ChromeClientImpl::shouldInterruptJavaScript()
-{
-    // FIXME: implement me
-    return false;
-}
-
 KeyboardUIMode ChromeClientImpl::keyboardUIMode()
 {
     return m_webView->tabsToLinks() ? KeyboardAccessTabsToLinks : KeyboardAccessDefault;
 }
 
 IntRect ChromeClientImpl::windowResizerRect() const
 {
     IntRect result;
     if (m_webView->client())
         result = m_webView->client()->windowResizerRect();
     return result;
 }
 
-void ChromeClientImpl::invalidateRootView(const IntRect&)
-{
-    notImplemented();
-}
-
 void ChromeClientImpl::invalidateContentsAndRootView(const IntRect& updateRect)
 {
     if (updateRect.isEmpty())
         return;
     m_webView->invalidateRect(updateRect);
 }
 
 void ChromeClientImpl::invalidateContentsForSlowScroll(const IntRect& updateRect)
 {
     invalidateContentsAndRootView(updateRect);
@@ skipping 182 matching lines @@
     m_webView->setPageScaleFactorLimits(computed.minimumScale, computed.maximumScale);
 #endif
 }
 
 void ChromeClientImpl::print(Frame* frame)
 {
     if (m_webView->client())
         m_webView->client()->printPage(WebFrameImpl::fromFrame(frame));
 }
 
-void ChromeClientImpl::exceededDatabaseQuota(Frame* frame, const String& databaseName, DatabaseDetails)
-{
-    // Chromium users cannot currently change the default quota
-}
-
-void ChromeClientImpl::reachedMaxAppCacheSize(int64_t spaceNeeded)
-{
-    ASSERT_NOT_REACHED();
-}
-
-void ChromeClientImpl::reachedApplicationCacheOriginQuota(SecurityOrigin*, int64_t)
-{
-    ASSERT_NOT_REACHED();
-}
-
 #if ENABLE(INPUT_TYPE_COLOR)
 PassOwnPtr<ColorChooser> ChromeClientImpl::createColorChooser(ColorChooserClient* chooserClient, const Color&)
 {
     OwnPtr<ColorChooserUIController> controller;
 #if ENABLE(PAGE_POPUP)
     controller = adoptPtr(new ColorChooserPopupUIController(this, chooserClient));
 #else
     controller = adoptPtr(new ColorChooserUIController(this, chooserClient));
 #endif
     controller->openUI();
@@ skipping 251 matching lines @@
     if (settings->acceleratedCompositingForAnimationEnabled())
         flags |= AnimationTrigger;
     if (settings->acceleratedCompositingForCanvasEnabled())
         flags |= CanvasTrigger;
     if (settings->acceleratedCompositingForScrollableFramesEnabled())
         flags |= ScrollableInnerFrameTrigger;
 
     return flags;
 }
 
-bool ChromeClientImpl::supportsFullscreenForNode(const Node* node)
-{
-    return false;
-}
-
 void ChromeClientImpl::enterFullscreenForNode(Node* node)

[adamk, 2013/04/30 00:05:07]

Actually, while I've got you here: can I remove these too? The
ASSERT_NOT_REACHED suggests yes, but the code in HTMLMediaElement seems like it
could call it...

[darin (slow to review), 2013/04/30 03:47:46]

Yes, this is all code for the old way of doing fullscreen for only the <video>
element.  We now just use the general purpose fullscreen code.  Some WebKit
ports were still shipping the old API IIRC.

[adamk, 2013/04/30 16:45:03]

I'll take care of this in a followup deleting all the old codepath (which
includes non-chromeclient stuff in HTMLMediaElement)

 {
     ASSERT_NOT_REACHED();
 }
 
 void ChromeClientImpl::exitFullscreenForNode(Node* node)
 {
     ASSERT_NOT_REACHED();
 }
 
-bool ChromeClientImpl::supportsFullScreenForElement(const Element* element, bool withKeyboard)
-{
-    return true;
-}
-
 void ChromeClientImpl::enterFullScreenForElement(Element* element)
 {
     m_webView->enterFullScreenForElement(element);
 }
 
 void ChromeClientImpl::exitFullScreenForElement(Element* element)
 {
     m_webView->exitFullScreenForElement(element);
 }
 
-void ChromeClientImpl::fullScreenRendererChanged(RenderBox*)
-{
-    notImplemented();
-}
-
-bool ChromeClientImpl::selectItemWritingDirectionIsNatural()
-{
-    return false;
-}
-
-bool ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection()
-{
-    return true;
-}
-
 bool ChromeClientImpl::hasOpenedPopup() const
 {
     return m_webView->hasOpenedPopup();
 }
 
 PassRefPtr<PopupMenu> ChromeClientImpl::createPopupMenu(PopupMenuClient* client) const
 {
     if (WebViewImpl::useExternalPopupMenus())
         return adoptRef(new ExternalPopupMenu(client, m_webView->client()));
 
@@ skipping 84 matching lines @@
 
     ASSERT_NOT_REACHED();
     return true;
 }
 
 void ChromeClientImpl::numWheelEventHandlersChanged(unsigned numberOfWheelHandlers)
 {
     m_webView->numberOfWheelEventHandlersChanged(numberOfWheelHandlers);
 }
 
-bool ChromeClientImpl::shouldAutoscrollForDragAndDrop(WebCore::RenderBox*) const
-{
-    return true;
-}
-
-
 void ChromeClientImpl::needTouchEvents(bool needsTouchEvents)
 {
     m_webView->hasTouchEventHandlers(needsTouchEvents);
 }
 
 bool ChromeClientImpl::requestPointerLock()
 {
     return m_webView->requestPointerLock();
 }
 
@@ skipping 18 matching lines @@
 {
     if (!m_webView->autofillClient())
         return;
     WebVector<WebNode> elementVector(static_cast<size_t>(elements.size()));
     size_t elementsCount = elements.size();
     for (size_t i = 0; i < elementsCount; ++i)
         elementVector[i] = elements[i];
     m_webView->autofillClient()->didAssociateFormControls(elementVector);
 }
 
-bool ChromeClientImpl::shouldNotifyOnFormChanges()
-{
-    return true;
-}
-
 #if ENABLE(NAVIGATOR_CONTENT_UTILS)
 PassOwnPtr<NavigatorContentUtilsClientImpl> NavigatorContentUtilsClientImpl::create(WebViewImpl* webView)
 {
     return adoptPtr(new NavigatorContentUtilsClientImpl(webView));
 }
 
 NavigatorContentUtilsClientImpl::NavigatorContentUtilsClientImpl(WebViewImpl* webView)
     : m_webView(webView)
 {
 }
 
 void NavigatorContentUtilsClientImpl::registerProtocolHandler(const String& scheme, const String& baseURL, const String& url, const String& title)
 { 
     m_webView->client()->registerProtocolHandler(scheme, baseURL, url, title);
 } 
 #endif
 
 } // namespace WebKit