Remove ChromeClient cruft

Remove ChromeClient cruft

Many ChromeClientImpl overrides simply return true, false, or do
nothing. This patch plumbs that information back up to WebCore and
thus simplifies a bunch of code.

R=darin@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149448

[darin (slow to review), 2013-04-29 23:59:06]

LGTM /dance

[adamk, 2013-04-30 00:05:07]

Thanks for the quick review!

https://codereview.chromium.org/13851023/diff/1/Source/WebKit/chromium/src/Ch...
File Source/WebKit/chromium/src/ChromeClientImpl.cpp (left):

https://codereview.chromium.org/13851023/diff/1/Source/WebKit/chromium/src/Ch...
Source/WebKit/chromium/src/ChromeClientImpl.cpp:999: void
ChromeClientImpl::enterFullscreenForNode(Node* node)
Actually, while I've got you here: can I remove these too? The
ASSERT_NOT_REACHED suggests yes, but the code in HTMLMediaElement seems like it
could call it...

[darin (slow to review), 2013-04-30 03:47:46]

https://codereview.chromium.org/13851023/diff/1/Source/WebKit/chromium/src/Ch...
File Source/WebKit/chromium/src/ChromeClientImpl.cpp (left):

https://codereview.chromium.org/13851023/diff/1/Source/WebKit/chromium/src/Ch...
Source/WebKit/chromium/src/ChromeClientImpl.cpp:999: void
ChromeClientImpl::enterFullscreenForNode(Node* node)
On 2013/04/30 00:05:07, adamk wrote:
> Actually, while I've got you here: can I remove these too? The
> ASSERT_NOT_REACHED suggests yes, but the code in HTMLMediaElement seems like
it
> could call it...

Yes, this is all code for the old way of doing fullscreen for only the <video>
element.  We now just use the general purpose fullscreen code.  Some WebKit
ports were still shipping the old API IIRC.

[adamk, 2013-04-30 16:45:03]

https://codereview.chromium.org/13851023/diff/1/Source/WebKit/chromium/src/Ch...
File Source/WebKit/chromium/src/ChromeClientImpl.cpp (left):

https://codereview.chromium.org/13851023/diff/1/Source/WebKit/chromium/src/Ch...
Source/WebKit/chromium/src/ChromeClientImpl.cpp:999: void
ChromeClientImpl::enterFullscreenForNode(Node* node)
On 2013/04/30 03:47:46, darin wrote:
> On 2013/04/30 00:05:07, adamk wrote:
> > Actually, while I've got you here: can I remove these too? The
> > ASSERT_NOT_REACHED suggests yes, but the code in HTMLMediaElement seems like
> it
> > could call it...
> 
> Yes, this is all code for the old way of doing fullscreen for only the <video>
> element.  We now just use the general purpose fullscreen code.  Some WebKit
> ports were still shipping the old API IIRC.

I'll take care of this in a followup deleting all the old codepath (which
includes non-chromeclient stuff in HTMLMediaElement)

[commit-bot: I haz the power, 2013-04-30 16:45:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adamk@chromium.org/13851023/1

[commit-bot: I haz the power, 2013-04-30 16:45:22]

Failed to apply patch for Source/core/dom/Document.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Document.cpp
  Hunk #1 succeeded at 4724 (offset -6 lines).
  Hunk #2 FAILED at 4997.
  Hunk #3 succeeded at 5688 (offset -6 lines).
  1 out of 3 hunks FAILED -- saving rejects to file
Source/core/dom/Document.cpp.rej

Patch:       Source/core/dom/Document.cpp
Index: Source/core/dom/Document.cpp
diff --git a/Source/core/dom/Document.cpp b/Source/core/dom/Document.cpp
index
e5fb9d1ba1cad97415af88843fd382318160bd0d..70830c36e3d7cacd07aea1139f33c1375f5c625f
100644
--- a/Source/core/dom/Document.cpp
+++ b/Source/core/dom/Document.cpp
@@ -4730,17 +4730,6 @@ void Document::requestFullScreenForElement(Element*
element, unsigned short flag
         if (!page() || !page()->settings()->fullScreenEnabled())
             break;
 
-        if (!page()->chrome()->client()->supportsFullScreenForElement(element,
flags & Element::ALLOW_KEYBOARD_INPUT)) {
-            // The new full screen API does not accept a "flags" parameter, so
fall back to disallowing
-            // keyboard input if the chrome client refuses to allow keyboard
input.
-            if (!inLegacyMozillaMode && flags & Element::ALLOW_KEYBOARD_INPUT)
{
-                flags &= ~Element::ALLOW_KEYBOARD_INPUT;
-                if
(!page()->chrome()->client()->supportsFullScreenForElement(element, false))
-                    break;
-            } else
-                break;
-        }
-
         // 2. Let doc be element's node document. (i.e. "this")
         Document* currentDoc = this;
 
@@ -5008,18 +4997,11 @@ void Document::setFullScreenRenderer(RenderFullScreen*
renderer)
     ASSERT(!m_fullScreenRenderer);
 
     m_fullScreenRenderer = renderer;
-    
-    // This notification can come in after the page has been destroyed.
-    if (page())
-       
page()->chrome()->client()->fullScreenRendererChanged(m_fullScreenRenderer);
 }
 
 void Document::fullScreenRendererDestroyed()
 {
     m_fullScreenRenderer = 0;
-
-    if (page())
-        page()->chrome()->client()->fullScreenRendererChanged(0);
 }
 
 void Document::setFullScreenRendererSize(const IntSize& size)
@@ -5705,7 +5687,7 @@ PassRefPtr<FontLoader> Document::fontloader()
 
 void Document::didAssociateFormControl(Element* element)
 {
-    if (!frame() || !frame()->page() ||
!frame()->page()->chrome()->client()->shouldNotifyOnFormChanges())
+    if (!frame() || !frame()->page())
         return;
     m_associatedFormControls.add(element);
     if (!m_didAssociateFormControlsTimer.isActive())

[commit-bot: I haz the power, 2013-04-30 16:54:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/adamk@chromium.org/13851023/9001

[commit-bot: I haz the power, 2013-04-30 18:52:26]

Failed to apply patch for Source/WebKit/chromium/src/ChromeClientImpl.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/WebKit/chromium/src/ChromeClientImpl.cpp
  Hunk #2 FAILED at 475.
  1 out of 9 hunks FAILED -- saving rejects to file
Source/WebKit/chromium/src/ChromeClientImpl.cpp.rej

Patch:       Source/WebKit/chromium/src/ChromeClientImpl.cpp
Index: Source/WebKit/chromium/src/ChromeClientImpl.cpp
diff --git a/Source/WebKit/chromium/src/ChromeClientImpl.cpp
b/Source/WebKit/chromium/src/ChromeClientImpl.cpp
index
a0b2b9c84dad493ab1fb12b1a36a41acb3cb0ccc..6a10160fc247443f8a175bf51690cfb4be6d1558
100644
--- a/Source/WebKit/chromium/src/ChromeClientImpl.cpp
+++ b/Source/WebKit/chromium/src/ChromeClientImpl.cpp
@@ -240,10 +240,6 @@ void ChromeClientImpl::focusedNodeChanged(Node* node)
     m_webView->client()->setKeyboardFocusURL(focusURL);
 }
 
-void ChromeClientImpl::focusedFrameChanged(Frame*)
-{
-}
-
 Page* ChromeClientImpl::createWindow(
     Frame* frame, const FrameLoadRequest& r, const WindowFeatures& features,
const NavigationAction& action)
 {
@@ -479,12 +475,6 @@ void ChromeClientImpl::setStatusbarText(const String&
message)
         m_webView->client()->setStatusText(message);
 }
 
-bool ChromeClientImpl::shouldInterruptJavaScript()
-{
-    // FIXME: implement me
-    return false;
-}
-
 KeyboardUIMode ChromeClientImpl::keyboardUIMode()
 {
     return m_webView->tabsToLinks() ? KeyboardAccessTabsToLinks :
KeyboardAccessDefault;
@@ -498,11 +488,6 @@ IntRect ChromeClientImpl::windowResizerRect() const
     return result;
 }
 
-void ChromeClientImpl::invalidateRootView(const IntRect&)
-{
-    notImplemented();
-}
-
 void ChromeClientImpl::invalidateContentsAndRootView(const IntRect& updateRect)
 {
     if (updateRect.isEmpty())
@@ -703,21 +688,6 @@ void ChromeClientImpl::print(Frame* frame)
         m_webView->client()->printPage(WebFrameImpl::fromFrame(frame));
 }
 
-void ChromeClientImpl::exceededDatabaseQuota(Frame* frame, const String&
databaseName, DatabaseDetails)
-{
-    // Chromium users cannot currently change the default quota
-}
-
-void ChromeClientImpl::reachedMaxAppCacheSize(int64_t spaceNeeded)
-{
-    ASSERT_NOT_REACHED();
-}
-
-void ChromeClientImpl::reachedApplicationCacheOriginQuota(SecurityOrigin*,
int64_t)
-{
-    ASSERT_NOT_REACHED();
-}
-
 #if ENABLE(INPUT_TYPE_COLOR)
 PassOwnPtr<ColorChooser>
ChromeClientImpl::createColorChooser(ColorChooserClient* chooserClient, const
Color&)
 {
@@ -989,11 +959,6 @@ ChromeClient::CompositingTriggerFlags
ChromeClientImpl::allowedCompositingTrigge
     return flags;
 }
 
-bool ChromeClientImpl::supportsFullscreenForNode(const Node* node)
-{
-    return false;
-}
-
 void ChromeClientImpl::enterFullscreenForNode(Node* node)
 {
     ASSERT_NOT_REACHED();
@@ -1004,11 +969,6 @@ void ChromeClientImpl::exitFullscreenForNode(Node* node)
     ASSERT_NOT_REACHED();
 }
 
-bool ChromeClientImpl::supportsFullScreenForElement(const Element* element,
bool withKeyboard)
-{
-    return true;
-}
-
 void ChromeClientImpl::enterFullScreenForElement(Element* element)
 {
     m_webView->enterFullScreenForElement(element);
@@ -1019,21 +979,6 @@ void ChromeClientImpl::exitFullScreenForElement(Element*
element)
     m_webView->exitFullScreenForElement(element);
 }
 
-void ChromeClientImpl::fullScreenRendererChanged(RenderBox*)
-{
-    notImplemented();
-}
-
-bool ChromeClientImpl::selectItemWritingDirectionIsNatural()
-{
-    return false;
-}
-
-bool ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection()
-{
-    return true;
-}
-
 bool ChromeClientImpl::hasOpenedPopup() const
 {
     return m_webView->hasOpenedPopup();
@@ -1138,12 +1083,6 @@ void
ChromeClientImpl::numWheelEventHandlersChanged(unsigned numberOfWheelHandle
     m_webView->numberOfWheelEventHandlersChanged(numberOfWheelHandlers);
 }
 
-bool ChromeClientImpl::shouldAutoscrollForDragAndDrop(WebCore::RenderBox*)
const
-{
-    return true;
-}
-
-
 void ChromeClientImpl::needTouchEvents(bool needsTouchEvents)
 {
     m_webView->hasTouchEventHandlers(needsTouchEvents);
@@ -1182,11 +1121,6 @@ void ChromeClientImpl::didAssociateFormControls(const
Vector<RefPtr<Element> >&
     m_webView->autofillClient()->didAssociateFormControls(elementVector);
 }
 
-bool ChromeClientImpl::shouldNotifyOnFormChanges()
-{
-    return true;
-}
-
 #if ENABLE(NAVIGATOR_CONTENT_UTILS)
 PassOwnPtr<NavigatorContentUtilsClientImpl>
NavigatorContentUtilsClientImpl::create(WebViewImpl* webView)
 {

[adamk, 2013-04-30 19:00:10]

Committed patchset #2 manually as r149448 (presubmit successful).