Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 13851023: Remove ChromeClient cruft (Closed)

Created:
7 years, 7 months ago by adamk
Modified:
7 years, 7 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, gavinp+loader_chromium.org, jchaffraix+rendering, Nate Chapin, jeez, vcarbune.chromium
Visibility:
Public.

Description

Remove ChromeClient cruft Many ChromeClientImpl overrides simply return true, false, or do nothing. This patch plumbs that information back up to WebCore and thus simplifies a bunch of code. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149448

Patch Set 1 #

Total comments: 3

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -240 lines) Patch
M Source/WebKit/chromium/src/ChromeClientImpl.h View 6 chunks +0 lines, -15 lines 0 comments Download
M Source/WebKit/chromium/src/ChromeClientImpl.cpp View 1 9 chunks +0 lines, -66 lines 0 comments Download
M Source/WebKit/chromium/src/WebPopupMenuImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/WebKit/chromium/src/WebPopupMenuImpl.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 3 chunks +1 line, -19 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 3 chunks +0 lines, -9 lines 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 chunk +1 line, -9 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 5 chunks +0 lines, -12 lines 0 comments Download
M Source/core/page/AutoscrollController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/Chrome.h View 4 chunks +0 lines, -7 lines 0 comments Download
M Source/core/page/Chrome.cpp View 5 chunks +0 lines, -34 lines 0 comments Download
M Source/core/page/ChromeClient.h View 6 chunks +0 lines, -32 lines 0 comments Download
M Source/core/page/FocusController.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/platform/HostWindow.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/platform/ScrollView.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/rendering/RenderMenuList.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M Source/modules/webdatabase/DatabaseContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webdatabase/DatabaseContext.cpp View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
adamk
7 years, 7 months ago (2013-04-29 23:48:51 UTC) #1
darin (slow to review)
LGTM /dance
7 years, 7 months ago (2013-04-29 23:59:06 UTC) #2
adamk
Thanks for the quick review! https://codereview.chromium.org/13851023/diff/1/Source/WebKit/chromium/src/ChromeClientImpl.cpp File Source/WebKit/chromium/src/ChromeClientImpl.cpp (left): https://codereview.chromium.org/13851023/diff/1/Source/WebKit/chromium/src/ChromeClientImpl.cpp#oldcode999 Source/WebKit/chromium/src/ChromeClientImpl.cpp:999: void ChromeClientImpl::enterFullscreenForNode(Node* node) Actually, ...
7 years, 7 months ago (2013-04-30 00:05:07 UTC) #3
darin (slow to review)
https://codereview.chromium.org/13851023/diff/1/Source/WebKit/chromium/src/ChromeClientImpl.cpp File Source/WebKit/chromium/src/ChromeClientImpl.cpp (left): https://codereview.chromium.org/13851023/diff/1/Source/WebKit/chromium/src/ChromeClientImpl.cpp#oldcode999 Source/WebKit/chromium/src/ChromeClientImpl.cpp:999: void ChromeClientImpl::enterFullscreenForNode(Node* node) On 2013/04/30 00:05:07, adamk wrote: > ...
7 years, 7 months ago (2013-04-30 03:47:46 UTC) #4
adamk
https://codereview.chromium.org/13851023/diff/1/Source/WebKit/chromium/src/ChromeClientImpl.cpp File Source/WebKit/chromium/src/ChromeClientImpl.cpp (left): https://codereview.chromium.org/13851023/diff/1/Source/WebKit/chromium/src/ChromeClientImpl.cpp#oldcode999 Source/WebKit/chromium/src/ChromeClientImpl.cpp:999: void ChromeClientImpl::enterFullscreenForNode(Node* node) On 2013/04/30 03:47:46, darin wrote: > ...
7 years, 7 months ago (2013-04-30 16:45:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/13851023/1
7 years, 7 months ago (2013-04-30 16:45:15 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/dom/Document.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-04-30 16:45:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/13851023/9001
7 years, 7 months ago (2013-04-30 16:54:11 UTC) #8
commit-bot: I haz the power
Failed to apply patch for Source/WebKit/chromium/src/ChromeClientImpl.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-04-30 18:52:26 UTC) #9
adamk
7 years, 7 months ago (2013-04-30 19:00:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 manually as r149448 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698