Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 1385093002: Enable CPU.RunExtendedInstructions test for win64 with clangcl (Closed)

Created:
5 years, 2 months ago by fbarchard1
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable CPU.RunExtendedInstructions test for win64 with clangcl clangcl supports Visual C (Intel) syntax for inline assembly for 64 bit, as well as 32 bit. Enable the existing instruction set test when built with clangcl. R=brucedawson@chromium.org BUG=chromium:168866 Committed: https://crrev.com/20028e68089da9762bfd62a6dedf167f3f017222 Cr-Commit-Position: refs/heads/master@{#352629}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M base/cpu_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
fbarchard1
5 years, 2 months ago (2015-10-05 21:47:12 UTC) #1
brucedawson
In this excellent article: http://chris.beams.io/posts/git-commit/ the author says: "A properly formed git commit subject line ...
5 years, 2 months ago (2015-10-05 21:58:48 UTC) #2
fbarchard
PTAL. Better?
5 years, 2 months ago (2015-10-05 22:50:49 UTC) #3
brucedawson
Much better. I still wonder if we wouldn't be better off creating an asm file ...
5 years, 2 months ago (2015-10-05 23:38:05 UTC) #4
brucedawson
On further thought, title might be clearer with "/clang" added to the end. Your call.
5 years, 2 months ago (2015-10-05 23:38:37 UTC) #5
fbarchard
On 2015/10/05 23:38:37, brucedawson wrote: > On further thought, title might be clearer with "/clang" ...
5 years, 2 months ago (2015-10-06 00:15:48 UTC) #7
fbarchard
Mark, can you approve as owner?
5 years, 2 months ago (2015-10-06 01:53:46 UTC) #9
Mark Mentovai
LGTM
5 years, 2 months ago (2015-10-06 13:15:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1385093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1385093002/1
5 years, 2 months ago (2015-10-06 17:20:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-06 17:26:37 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 17:27:28 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20028e68089da9762bfd62a6dedf167f3f017222
Cr-Commit-Position: refs/heads/master@{#352629}

Powered by Google App Engine
This is Rietveld 408576698