Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(823)

Unified Diff: base/cpu_unittest.cc

Issue 1385093002: Enable CPU.RunExtendedInstructions test for win64 with clangcl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/cpu_unittest.cc
diff --git a/base/cpu_unittest.cc b/base/cpu_unittest.cc
index 931509738fe7ace50bcd576b9fd5f738eeb0306e..ec14620f98c91a79a9e6ddc1e40a983cabd621b4 100644
--- a/base/cpu_unittest.cc
+++ b/base/cpu_unittest.cc
@@ -26,7 +26,7 @@ TEST(CPU, RunExtendedInstructions) {
ASSERT_TRUE(cpu.has_sse());
ASSERT_TRUE(cpu.has_sse2());
-// TODO(fbarchard): consider enabling for clangcl.
+// GCC and clang instruction test.
#if defined(COMPILER_GCC)
// Execute an MMX instruction.
__asm__ __volatile__("emms\n" : : : "mm0");
@@ -67,8 +67,9 @@ TEST(CPU, RunExtendedInstructions) {
__asm__ __volatile__("vpunpcklbw %%ymm0, %%ymm0, %%ymm0\n" : : : "xmm0");
}
-// TODO(jschuh): crbug.com/168866 Find a way to enable this on Win64.
-#elif defined(COMPILER_MSVC) && defined(ARCH_CPU_32_BITS)
+// Visual C 32 bit and ClangCL 32/64 bit test.
+#elif defined(COMPILER_MSVC) && (defined(ARCH_CPU_32_BITS) || \
+ (defined(ARCH_CPU_64_BITS) && defined(__clang__)))
// Execute an MMX instruction.
__asm emms;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698