Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1384953002: [turbofan] Move global constant optimization to AstGraphBuilder. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Move global constant optimization to AstGraphBuilder. Optimizing global constants such as "NaN", "Infinity" and "undefined" is best performed during graph building. Then the optimization and lowering passes only need to deal with real loads in case of JSLoadGlobal. R=mstarzinger@chromium.org BUG=v8:4470 LOG=n Committed: https://crrev.com/74ae226b94f8951cf359f382d1817f08391844f7 Cr-Commit-Position: refs/heads/master@{#31135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -62 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +7 lines, -1 line 0 comments Download
M src/compiler/js-type-feedback.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 1 chunk +0 lines, -35 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (3 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-05 13:17:19 UTC) #1
Benedikt Meurer
Hey Michi, As discussed offline, unify this in the AstGraphBuilder. Please take a look. Thanks, ...
5 years, 2 months ago (2015-10-05 13:17:50 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384953002/1
5 years, 2 months ago (2015-10-07 07:22:15 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-07 07:46:20 UTC) #6
Michael Starzinger
LGTM.
5 years, 2 months ago (2015-10-07 08:15:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384953002/1
5 years, 2 months ago (2015-10-07 08:16:15 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-07 08:19:30 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 08:19:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74ae226b94f8951cf359f382d1817f08391844f7
Cr-Commit-Position: refs/heads/master@{#31135}

Powered by Google App Engine
This is Rietveld 408576698