Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: test/unittests/compiler/js-typed-lowering-unittest.cc

Issue 1384953002: [turbofan] Move global constant optimization to AstGraphBuilder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/compiler/js-typed-lowering-unittest.cc
diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc b/test/unittests/compiler/js-typed-lowering-unittest.cc
index 5afb6e47b3027a706d85c1c88853f1c637d85b53..7d7e267043d8468b298bd7fa2327d473cc87b324 100644
--- a/test/unittests/compiler/js-typed-lowering-unittest.cc
+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc
@@ -862,41 +862,6 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithSafeKey) {
// -----------------------------------------------------------------------------
-// JSLoadGlobal
-
-
-TEST_F(JSTypedLoweringTest, JSLoadGlobalConstants) {
- Handle<String> names[] = {
- Handle<String>(isolate()->heap()->undefined_string(), isolate()),
- Handle<String>(isolate()->heap()->infinity_string(), isolate()),
- Handle<String>(isolate()->heap()->nan_string(), isolate()) // --
- };
- Matcher<Node*> matches[] = {
- IsHeapConstant(
- Handle<HeapObject>(isolate()->heap()->undefined_value(), isolate())),
- IsNumberConstant(std::numeric_limits<double>::infinity()),
- IsNumberConstant(IsNaN()) // --
- };
-
- VectorSlotPair feedback;
- Node* global = UndefinedConstant();
- Node* vector = UndefinedConstant();
- Node* context = UndefinedConstant();
- Node* effect = graph()->start();
- Node* control = graph()->start();
-
- for (size_t i = 0; i < arraysize(names); i++) {
- Reduction r = Reduce(graph()->NewNode(
- javascript()->LoadGlobal(names[i], feedback), context, global, vector,
- context, EmptyFrameState(), EmptyFrameState(), effect, control));
-
- ASSERT_TRUE(r.Changed());
- EXPECT_THAT(r.replacement(), matches[i]);
- }
-}
-
-
-// -----------------------------------------------------------------------------
// JSLoadNamed
« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698