Revert of Don't report promise rejection events during the microtask checkpoint

Revert of Don't report promise rejection events during the microtask checkpoint (patchset #6 id:100001 of https://codereview.chromium.org/1381693002/ )

Reason for revert:
Causes leaks in following tests:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/builds/14655

fast/dom/promise-rejection-events-isolated-worlds.html
web-animations-api/player-ready-promise.html
http/tests/fetch/window/fetch.html
inspector/sources/debugger-pause/debugger-pause-on-promise-rejection.html
inspector-enabled/console/console-uncaught-promise-no-inspector.html
http/tests/serviceworker/fetch-request-resources.html
inspector/console/console-revoke-error.html
inspector/console/console-uncaught-promise.html
fast/dom/promise-rejection-events-attached-in-event.html
inspector/sources/debugger/debugger-uncaught-promise-on-pause.html
imported/web-platform-tests/screen-orientation/lock-bad-argument.html
web-animations-api/player-finished-promise.html
http/tests/dom/promise-rejection-events.html
fast/css/fontfaceset-add-remove-while-loading.html

Original issue's description:
> Don't report promise rejection events during the microtask checkpoint
>
> instead post them to the message loop.
>
> BUG=495801
>
> Committed: https://crrev.com/31bc5867e1112af8b82d780b47fcb3a6f337a8a0
> Cr-Commit-Position: refs/heads/master@{#352251}

TBR=domenic@chromium.org,haraken@chromium.org,hiroshige@chromium.org,sigbjornf@opera.com,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=495801
Committed: https://crrev.com/1edacd5d66d5b1642a4c4d9a411717150be8e8e9
Cr-Commit-Position: refs/heads/master@{#352289}

[yosin_UTC9, 2015-10-05 04:06:19]

Created Revert of Don't report promise rejection events during the microtask
checkpoint

[commit-bot: I haz the power, 2015-10-05 04:06:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1384913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1384913002/1

[haraken, 2015-10-05 04:06:49]

LGTM

[commit-bot: I haz the power, 2015-10-05 04:06:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-05 04:06:53]

Failed to apply patch for
third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp:
While running git apply --index -3 -p1;
  error: patch failed:
third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp:229
  Falling back to three-way merge...
  Applied patch to
'third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp' with
conflicts.
  U third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

Patch:       third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
Index: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
index
e88c277eb7a4b4a7eebe4782af8811efe5afd822..3ed8d247ee5d1659fbe25554de1e4a079984cff1
100644
--- a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
@@ -15,12 +15,6 @@
 #include "core/inspector/ConsoleMessage.h"
 #include "core/inspector/ScriptArguments.h"
 #include "platform/RuntimeEnabledFeatures.h"
-#include "platform/Task.h"
-#include "public/platform/Platform.h"
-#include "public/platform/WebScheduler.h"
-#include "public/platform/WebTaskRunner.h"
-#include "public/platform/WebThread.h"
-#include "wtf/Functional.h"
 
 namespace blink {
 
@@ -65,7 +59,7 @@
         // Either collected or https://crbug.com/450330
         if (value.IsEmpty() || !value->IsPromise())
             return;
-        ASSERT(!hasHandler());
+        ASSERT(!v8::Local<v8::Promise>::Cast(value)->HasHandler());
 
         EventTarget* target = executionContext->errorEventTarget();
         if (RuntimeEnabledFeatures::promiseRejectionEventEnabled() && target) {
@@ -128,27 +122,6 @@
             consoleMessage->setRelatedMessageId(m_consoleMessageId);
             executionContext->addConsoleMessage(consoleMessage.release());
         }
-    }
-
-    void makePromiseWeak()
-    {
-        ASSERT(!m_promise.isEmpty() && !m_promise.isWeak());
-        m_promise.setWeak(this, &Message::didCollectPromise);
-    }
-
-    void makePromiseStrong()
-    {
-        ASSERT(!m_promise.isEmpty() && m_promise.isWeak());
-        m_promise.clearWeak();
-    }
-
-    bool hasHandler()
-    {
-        if (isCollected())
-            return false;
-        ScriptState::Scope scope(m_scriptState);
-        v8::Local<v8::Value> value =
m_promise.newLocal(m_scriptState->isolate());
-        return v8::Local<v8::Promise>::Cast(value)->HasHandler();
     }
 
 private:
@@ -166,6 +139,7 @@
         , m_collected(false)
         , m_shouldLogToConsole(true)
     {
+        m_promise.setWeak(this, &Message::didCollectPromise);
     }
 
     static void didCollectPromise(const v8::WeakCallbackInfo<Message>& data)
@@ -219,8 +193,7 @@
     for (size_t i = 0; i < m_reportedAsErrors.size(); ++i) {
         auto& message = m_reportedAsErrors.at(i);
         if (!message->isCollected() && message->hasPromise(data.GetPromise()))
{
-            message->makePromiseStrong();
-           
Platform::current()->currentThread()->scheduler()->timerTaskRunner()->postTask(FROM_HERE,
new Task(bind(&RejectedPromises::revokeNow, this, message.release())));
+            message->revoke();
             m_reportedAsErrors.remove(i);
             return;
         }
@@ -229,23 +202,10 @@
 
 void RejectedPromises::dispose()
 {
-    if (!m_queue.isEmpty()) {
-        OwnPtrWillBeRawPtr<WillBeHeapDeque<OwnPtrWillBeMember<Message>>> queue
= adoptPtr(new WillBeHeapDeque<OwnPtrWillBeMember<Message>>());
-        queue->swap(m_queue);
-        processQueueNow(queue.release());
-    }
+    processQueue();
 }
 
 void RejectedPromises::processQueue()
-{
-    if (m_queue.isEmpty())
-        return;
-    OwnPtrWillBeRawPtr<WillBeHeapDeque<OwnPtrWillBeMember<Message>>> queue =
adoptPtr(new WillBeHeapDeque<OwnPtrWillBeMember<Message>>());
-    queue->swap(m_queue);
-   
Platform::current()->currentThread()->scheduler()->timerTaskRunner()->postTask(FROM_HERE,
new Task(bind(&RejectedPromises::processQueueNow, this, queue.release())));
-}
-
-void
RejectedPromises::processQueueNow(PassOwnPtrWillBeRawPtr<WillBeHeapDeque<OwnPtrWillBeMember<Message>>>
queue)
 {
     // Remove collected handlers.
     for (size_t i = 0; i < m_reportedAsErrors.size();) {
@@ -255,21 +215,16 @@
             ++i;
     }
 
-    while (!queue->isEmpty()) {
-        OwnPtrWillBeRawPtr<Message> message = queue->takeFirst();
-        if (!message->hasHandler()) {
-            message->report();
-            message->makePromiseWeak();
-            m_reportedAsErrors.append(message.release());
-            if (m_reportedAsErrors.size() >
maxReportedHandlersPendingResolution)
-                m_reportedAsErrors.remove(0,
maxReportedHandlersPendingResolution / 10);
-        }
-    }
-}
-
-void RejectedPromises::revokeNow(PassOwnPtrWillBeRawPtr<Message> message)
-{
-    message->revoke();
+    while (!m_queue.isEmpty()) {
+        OwnPtrWillBeRawPtr<Message> message = m_queue.takeFirst();
+        if (message->isCollected())
+            continue;
+
+        message->report();
+        m_reportedAsErrors.append(message.release());
+        if (m_reportedAsErrors.size() > maxReportedHandlersPendingResolution)
+            m_reportedAsErrors.remove(0, maxReportedHandlersPendingResolution /
10);
+    }
 }
 
 } // namespace blink

[commit-bot: I haz the power, 2015-10-05 04:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[yosin_UTC9, 2015-10-05 04:16:09]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-10-05 04:16:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1384913002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1384913002/1

[commit-bot: I haz the power, 2015-10-05 04:17:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-05 04:17:58]

Patchset 1 (id:??) landed as
https://crrev.com/1edacd5d66d5b1642a4c4d9a411717150be8e8e9
Cr-Commit-Position: refs/heads/master@{#352289}