third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h - Issue 1384913002: Revert of Don't report promise rejection events during the microtask checkpoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

Issue 1384913002: Revert of Don't report promise rejection events during the microtask checkpoint (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h b/third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

index 3521d0461c0ee245565aec2dcc28ebef4ca51422..3cd5e06d40e98e029dded90d2f9fa3d00a2be830 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScopedPersistent.h

@@ -72,11 +72,6 @@

m_handle.SetWeak(parameters, callback, type);

}

- void clearWeak()

- {

- m_handle.template ClearWeak<void>();

- }

bool isEmpty() const { return m_handle.IsEmpty(); }

bool isWeak() const { return m_handle.IsWeak(); }