Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again.

Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again.

Without that, it has a few false positives about out-of-bounds array accesses.
Also makes the clang static-analyzer happy.

Original code review from Sven Panne:
https://codereview.chromium.org/790723002/

CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg

Committed: https://crrev.com/d068574e641e28f05dcde89ddc9a1d0ec6f6f308
Cr-Commit-Position: refs/heads/master@{#31105}

[skomski, 2015-10-04 13:19:20]

karl@skomski.com changed reviewers:
+ bmeurer@chromium.org, jochen@chromium.org

[skomski, 2015-10-04 13:21:06]

PTAL Updated to resolve on V8 arm gcc:

.././src/arguments.h: In function ‘v8::internal::Object*
v8::internal::Runtime_ArrayConstructorWithSubclassing(int,
v8::internal::Object**, v8::internal::Isolate*)’:
.././include/v8config.h:370:63: error: assuming signed overflow does not occur
when assuming that (X - c) > X is always false [-Werror=strict-overflow]
 # define V8_UNLIKELY(condition) (__builtin_expect(!!(condition), 0))
                                                               ^
.././src/base/logging.h:47:9: note: in expansion of macro ‘V8_UNLIKELY’
     if (V8_UNLIKELY(!(condition))) {                                 \
         ^
.././src/base/logging.h:154:32: note: in expansion of macro ‘CHECK’
 #define DCHECK(condition)      CHECK(condition)
                                ^
.././src/arguments.h:35:5: note: in expansion of macro ‘DCHECK’
     DCHECK(0 <= index && index < length_);

[Benedikt Meurer, 2015-10-04 15:21:10]

lgtm from my side

[skomski, 2015-10-04 16:44:04]

The CQ bit was checked by karl@skomski.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-04 16:44:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1384873002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1384873002/20001

[commit-bot: I haz the power, 2015-10-04 16:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-04 16:57:51]

Dry run: Try jobs failed on following builders:
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)

[skomski, 2015-10-04 17:21:03]

The CQ bit was checked by karl@skomski.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-04 17:21:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1384873002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1384873002/40001

[skomski, 2015-10-04 17:46:21]

The CQ bit was unchecked by karl@skomski.com

[skomski, 2015-10-04 17:58:33]

It would be great if someone could check more try-bots especially
v8_linux_arm_dbg. Thanks!

[Benedikt Meurer, 2015-10-04 18:21:53]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-04 18:22:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1384873002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1384873002/40001

[commit-bot: I haz the power, 2015-10-04 19:00:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-04 19:00:05]

Dry run: This issue passed the CQ dry run.

[skomski, 2015-10-05 14:52:03]

The CQ bit was checked by karl@skomski.com to run a CQ dry run

[commit-bot: I haz the power, 2015-10-05 14:52:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1384873002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1384873002/40001

[jochen (gone - plz use gerrit), 2015-10-05 15:23:36]

lgtm

[skomski, 2015-10-05 15:39:58]

The CQ bit was unchecked by karl@skomski.com

[skomski, 2015-10-05 15:40:05]

The CQ bit was checked by karl@skomski.com

[skomski, 2015-10-05 15:40:05]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1384873002/#ps40001
(title: "fix unintialized variable")

[commit-bot: I haz the power, 2015-10-05 15:40:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1384873002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1384873002/40001

[commit-bot: I haz the power, 2015-10-05 16:29:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-05 16:29:25]

Try jobs failed on following builders:
  v8_linux_layout_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_layout_dbg/builds/...)

[skomski, 2015-10-05 16:32:07]

The CQ bit was checked by karl@skomski.com

[commit-bot: I haz the power, 2015-10-05 16:32:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1384873002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1384873002/40001

[commit-bot: I haz the power, 2015-10-05 16:34:41]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-10-05 16:35:06]

Patchset 3 (id:??) landed as
https://crrev.com/d068574e641e28f05dcde89ddc9a1d0ec6f6f308
Cr-Commit-Position: refs/heads/master@{#31105}

[Michael Achenbach, 2015-10-05 18:55:37]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1376113005/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Breaks the gcc 4.8 bot:
http://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/....

[Michael Achenbach, 2015-10-05 19:53:34]

FYI: Also broke:
http://build.chromium.org/p/client.v8/builders/V8%20Arm/builds/3141