Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1581)

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1384873002: Reland: Introduce a V8_NORETURN macro and use it to make GCC 4.9.2 happy again. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: fix unintialized variable Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/spaces-inl.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/test-bytecode-generator.cc
diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc
index c41dee3df9beae2c73dda7ea0252e570974e97ea..98b4723cc0b611281a63e44c37cf91e97e3f761f 100644
--- a/test/cctest/interpreter/test-bytecode-generator.cc
+++ b/test/cctest/interpreter/test-bytecode-generator.cc
@@ -157,6 +157,7 @@ static void CheckBytecodeArrayEqual(struct ExpectedSnippet<T> expected,
switch (Bytecodes::SizeOfOperand(operand_type)) {
case OperandSize::kNone:
UNREACHABLE();
+ return;
case OperandSize::kByte:
expected_operand =
static_cast<uint32_t>(expected.bytecode[operand_index]);
@@ -165,6 +166,9 @@ static void CheckBytecodeArrayEqual(struct ExpectedSnippet<T> expected,
expected_operand = Bytecodes::ShortOperandFromBytes(
&expected.bytecode[operand_index]);
break;
+ default:
+ UNREACHABLE();
+ return;
}
if (raw_operand != expected_operand) {
std::ostringstream stream;
« no previous file with comments | « src/heap/spaces-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698