Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1384673002: The metadata part of TypeFeedbackVector is extracted to TypeFeedbackMetadata array. (Closed)

Created:
5 years, 2 months ago by Igor Sheludko
Modified:
5 years, 2 months ago
Reviewers:
mvstanton, ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

The metadata part of TypeFeedbackVector is extracted to TypeFeedbackMetadata array. Thus TypeFeedbackMetadata can now be shared between different native contexts. Committed: https://crrev.com/1d7c9c8139e99da09047219c58d6f060abe78c8e Cr-Commit-Position: refs/heads/master@{#31143}

Patch Set 1 : #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -158 lines) Patch
M src/compiler.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M src/factory.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects-printer.cc View 2 chunks +28 lines, -2 lines 0 comments Download
M src/type-feedback-vector.h View 1 6 chunks +65 lines, -33 lines 0 comments Download
M src/type-feedback-vector.cc View 1 9 chunks +90 lines, -71 lines 0 comments Download
M src/type-feedback-vector-inl.h View 6 chunks +39 lines, -18 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 6 chunks +6 lines, -5 lines 0 comments Download
M test/cctest/test-feedback-vector.h View 2 chunks +10 lines, -2 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 6 chunks +15 lines, -19 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Igor Sheludko
PTAL
5 years, 2 months ago (2015-10-02 10:10:24 UTC) #3
Igor Sheludko
PTAL
5 years, 2 months ago (2015-10-02 10:11:21 UTC) #4
mvstanton
nice! LGTM.
5 years, 2 months ago (2015-10-07 09:52:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384673002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384673002/60001
5 years, 2 months ago (2015-10-07 09:53:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6428)
5 years, 2 months ago (2015-10-07 09:58:15 UTC) #10
Igor Sheludko
Ulan, PTAL at heap part.
5 years, 2 months ago (2015-10-07 10:02:13 UTC) #12
ulan
heap part lgtm.
5 years, 2 months ago (2015-10-07 10:26:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384673002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384673002/60001
5 years, 2 months ago (2015-10-07 10:30:00 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 2 months ago (2015-10-07 10:33:29 UTC) #16
commit-bot: I haz the power
5 years, 2 months ago (2015-10-07 10:33:40 UTC) #17
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1d7c9c8139e99da09047219c58d6f060abe78c8e
Cr-Commit-Position: refs/heads/master@{#31143}

Powered by Google App Engine
This is Rietveld 408576698