The metadata part of TypeFeedbackVector is extracted to TypeFeedbackMetadata array.

src/type-feedback-vector-inl.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_TYPE_FEEDBACK_VECTOR_INL_H_
 #define V8_TYPE_FEEDBACK_VECTOR_INL_H_
 
 #include "src/type-feedback-vector.h"
 
 namespace v8 {
 namespace internal {
 
 
 template <typename Derived>
 FeedbackVectorSlot FeedbackVectorSpecBase<Derived>::AddSlot(
     FeedbackVectorSlotKind kind) {
   Derived* derived = static_cast<Derived*>(this);
 
   int slot = derived->slots();
-  int entries_per_slot = TypeFeedbackVector::GetSlotSize(kind);
+  int entries_per_slot = TypeFeedbackMetadata::GetSlotSize(kind);
   derived->append(kind);
   for (int i = 1; i < entries_per_slot; i++) {
     derived->append(FeedbackVectorSlotKind::INVALID);
   }
   return FeedbackVectorSlot(slot);
 }
 
 
 // static
+TypeFeedbackMetadata* TypeFeedbackMetadata::cast(Object* obj) {
+  DCHECK(obj->IsTypeFeedbackVector());
+  return reinterpret_cast<TypeFeedbackMetadata*>(obj);
+}
+
+
+int TypeFeedbackMetadata::slot_count() const {
+  if (length() == 0) return 0;
+  DCHECK(length() > kReservedIndexCount);
+  return Smi::cast(get(kSlotsCountIndex))->value();
+}
+
+
+// static
 TypeFeedbackVector* TypeFeedbackVector::cast(Object* obj) {
   DCHECK(obj->IsTypeFeedbackVector());
   return reinterpret_cast<TypeFeedbackVector*>(obj);
 }
 
 
-int TypeFeedbackVector::GetSlotSize(FeedbackVectorSlotKind kind) {
+int TypeFeedbackMetadata::GetSlotSize(FeedbackVectorSlotKind kind) {
   DCHECK_NE(FeedbackVectorSlotKind::INVALID, kind);
   DCHECK_NE(FeedbackVectorSlotKind::KINDS_NUMBER, kind);
   return kind == FeedbackVectorSlotKind::GENERAL ? 1 : 2;
 }
 
 
 bool TypeFeedbackVector::is_empty() const {
   if (length() == 0) return true;
-  DCHECK(length() >= kReservedIndexCount);
+  DCHECK(length() > kReservedIndexCount);
   return false;
 }
 
 
-int TypeFeedbackVector::Slots() const {
+int TypeFeedbackVector::slot_count() const {
   if (length() == 0) return 0;
-  DCHECK(length() >= kReservedIndexCount);
-  return Smi::cast(get(kSlotsCountIndex))->value();
+  DCHECK(length() > kReservedIndexCount);
+  return length() - kReservedIndexCount;
 }
 
 
+TypeFeedbackMetadata* TypeFeedbackVector::metadata() const {
+  return is_empty() ? TypeFeedbackMetadata::cast(GetHeap()->empty_fixed_array())
+                    : TypeFeedbackMetadata::cast(get(kMetadataIndex));
+}
+
+
+FeedbackVectorSlotKind TypeFeedbackVector::GetKind(
+    FeedbackVectorSlot slot) const {
+  DCHECK(!is_empty());
+  return metadata()->GetKind(slot);
+}
+
+
 int TypeFeedbackVector::ic_with_type_info_count() {
   return length() > 0 ? Smi::cast(get(kWithTypesIndex))->value() : 0;
 }
 
 
 void TypeFeedbackVector::change_ic_with_type_info_count(int delta) {
   if (delta == 0) return;
   int value = ic_with_type_info_count() + delta;
   // Could go negative because of the debugger.
   if (value >= 0) {
     set(kWithTypesIndex, Smi::FromInt(value));
   }
 }
 
 
 int TypeFeedbackVector::ic_generic_count() {
   return length() > 0 ? Smi::cast(get(kGenericCountIndex))->value() : 0;
 }
 
 
 void TypeFeedbackVector::change_ic_generic_count(int delta) {
   if (delta == 0) return;
   int value = ic_generic_count() + delta;
   if (value >= 0) {
     set(kGenericCountIndex, Smi::FromInt(value));
   }
 }
 
 
-int TypeFeedbackVector::ic_metadata_length() const {
-  return VectorICComputer::word_count(Slots());
-}
-
-
 int TypeFeedbackVector::GetIndex(FeedbackVectorSlot slot) const {
-  DCHECK(slot.ToInt() < Slots());
-  return kReservedIndexCount + ic_metadata_length() + slot.ToInt();
+  DCHECK(slot.ToInt() < slot_count());
+  return kReservedIndexCount + slot.ToInt();
 }
 
 
 // Conversion from an integer index to either a slot or an ic slot. The caller
 // should know what kind she expects.
 FeedbackVectorSlot TypeFeedbackVector::ToSlot(int index) const {
-  DCHECK(index >= kReservedIndexCount + ic_metadata_length() &&
-         index < length());
-  return FeedbackVectorSlot(index - ic_metadata_length() - kReservedIndexCount);
+  DCHECK(index >= kReservedIndexCount && index < length());
+  return FeedbackVectorSlot(index - kReservedIndexCount);
 }
 
 
 Object* TypeFeedbackVector::Get(FeedbackVectorSlot slot) const {
   return get(GetIndex(slot));
 }
 
 
 void TypeFeedbackVector::Set(FeedbackVectorSlot slot, Object* value,
                              WriteBarrierMode mode) {
@@ skipping 20 matching lines @@
   return isolate->heap()->uninitialized_symbol();
 }
 
 
 Object* FeedbackNexus::GetFeedback() const { return vector()->Get(slot()); }
 
 
 Object* FeedbackNexus::GetFeedbackExtra() const {
 #ifdef DEBUG
   FeedbackVectorSlotKind kind = vector()->GetKind(slot());
-  DCHECK_LT(1, TypeFeedbackVector::GetSlotSize(kind));
+  DCHECK_LT(1, TypeFeedbackMetadata::GetSlotSize(kind));
 #endif
   int extra_index = vector()->GetIndex(slot()) + 1;
   return vector()->get(extra_index);
 }
 
 
 void FeedbackNexus::SetFeedback(Object* feedback, WriteBarrierMode mode) {
   vector()->Set(slot(), feedback, mode);
 }
 
 
 void FeedbackNexus::SetFeedbackExtra(Object* feedback_extra,
                                      WriteBarrierMode mode) {
 #ifdef DEBUG
   FeedbackVectorSlotKind kind = vector()->GetKind(slot());
-  DCHECK_LT(1, TypeFeedbackVector::GetSlotSize(kind));
+  DCHECK_LT(1, TypeFeedbackMetadata::GetSlotSize(kind));
 #endif
   int index = vector()->GetIndex(slot()) + 1;
   vector()->set(index, feedback_extra, mode);
 }
 
 
 Isolate* FeedbackNexus::GetIsolate() const { return vector()->GetIsolate(); }
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_TYPE_FEEDBACK_VECTOR_INL_H_