Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1384663005:
Fix flash of icon border when network error page is loaded (Closed)
|
Created:
5 years, 2 months ago by edwardjung Modified:
5 years, 2 months ago Reviewers:
mmenke CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@2490 Target Ref:
refs/pending/branch-heads/2490 Project:
chromium Visibility:
Public. |
DescriptionFix flash of icon border when network error page is loaded
Switching the icon to be a div instead of an image tag. An image tag with no src or empty CSS content property shows a border which can't be overridden by CSS.
BUG=522408
TBR=jochen@chromium.org
NOTRY=true
NOPRESUBMIT=true
Review URL: https://codereview.chromium.org/1371213002
Cr-Commit-Position: refs/heads/master@{#351302}
(cherry picked from commit 51500bb57c4b7e26e48d87768da935bc432f6870)
Patch Set 1 #
Messages
Total messages: 29 (10 generated)
edwardjung@chromium.org changed reviewers: + mmenke@chromium.org
Thanks for helping out again Matt.
The CQ bit was checked by mmenke@chromium.org
On 2015/10/02 18:51:52, edwardjung wrote: > Thanks for helping out again Matt. May need to add a TBR= line...let's see how it works without it.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384663005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384663005/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by mmenke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384663005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384663005/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
On 2015/10/02 18:54:40, mmenke wrote: > On 2015/10/02 18:51:52, edwardjung wrote: > > Thanks for helping out again Matt. > > May need to add a TBR= line...let's see how it works without it. Added a TBR
Do you need to LGTM it before committing?
On 2015/10/02 19:02:15, edwardjung wrote: > Do you need to LGTM it before committing? Hrm...Did think I had to, with the TBR... LGTM!
The CQ bit was checked by mmenke@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384663005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384663005/1
The CQ bit was unchecked by commit-bot@chromium.org
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them
The CQ bit was checked by mmenke@chromium.org
On 2015/10/02 19:05:16, commit-bot: I haz the power wrote: > CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true > and NOPRESUBMIT=true in order for the CQ to process them Hope we'll manage to merge it by the time M60 goes to stable. :)
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384663005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384663005/1
On 2015/10/02 19:06:56, mmenke wrote: > On 2015/10/02 19:05:16, commit-bot: I haz the power wrote: > > CLs for remote refs other than refs/pending/heads/master must contain > NOTRY=true > > and NOPRESUBMIT=true in order for the CQ to process them > > Hope we'll manage to merge it by the time M60 goes to stable. :) Hope so, but I think users can live with the border for a couple of releases…
The CQ bit was unchecked by commit-bot@chromium.org
Failed to commit the patch.
The CQ bit was unchecked by commit-bot@chromium.org
On 2015/10/02 19:13:52, commit-bot: I haz the power wrote: > Failed to commit the patch. Hrm...despite that, it posted a commit message on the bug...
On 2015/10/02 19:21:00, mmenke wrote: > On 2015/10/02 19:13:52, commit-bot: I haz the power wrote: > > Failed to commit the patch. > > Hrm...despite that, it posted a commit message on the bug... Thanks for your perseverance!
On 2015/10/05 09:57:45, edwardjung wrote: > On 2015/10/02 19:21:00, mmenke wrote: > > On 2015/10/02 19:13:52, commit-bot: I haz the power wrote: > > > Failed to commit the patch. > > > > Hrm...despite that, it posted a commit message on the bug... > > Thanks for your perseverance! As I replied on the internal email thread, the CQ tried to run git push several times, each time it failed. However, apparently, the commit was actually pushed, and later different service processed it and updated commit position and yet another service bugdroid updated the bug. So, this CL has effectively landed.
Message was sent while issue was closed.
On 2015/10/06 16:17:21, tandrii(chromium) wrote: > On 2015/10/05 09:57:45, edwardjung wrote: > > On 2015/10/02 19:21:00, mmenke wrote: > > > On 2015/10/02 19:13:52, commit-bot: I haz the power wrote: > > > > Failed to commit the patch. > > > > > > Hrm...despite that, it posted a commit message on the bug... > > > > Thanks for your perseverance! > > As I replied on the internal email thread, the CQ tried to run git push several > times, each time it failed. However, apparently, the commit was actually pushed, > and later different service processed it and updated commit position and yet > another service bugdroid updated the bug. So, this CL has effectively landed. Thank you! |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
