Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1278)

Issue 1371213002: Fix flash of icon border when network error interstitial is loaded (Closed)

Created:
5 years, 2 months ago by edwardjung
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flash of icon border when network error page is loaded Switching the icon to be a div instead of an image tag. An image tag with no src or empty CSS content property shows a border which can't be overridden by CSS. BUG=522408 Committed: https://crrev.com/51500bb57c4b7e26e48d87768da935bc432f6870 Cr-Commit-Position: refs/heads/master@{#351302}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/renderer/resources/neterror.css View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/resources/neterror.html View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
edwardjung
Please take a look at this small fix to the network error interstitial. Thanks.
5 years, 2 months ago (2015-09-28 18:47:55 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-09-29 07:33:31 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371213002/1
5 years, 2 months ago (2015-09-29 09:36:31 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/126865)
5 years, 2 months ago (2015-09-29 09:50:54 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371213002/1
5 years, 2 months ago (2015-09-29 12:34:15 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-29 12:40:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371213002/1
5 years, 2 months ago (2015-09-29 13:07:23 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 13:13:35 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/51500bb57c4b7e26e48d87768da935bc432f6870 Cr-Commit-Position: refs/heads/master@{#351302}
5 years, 2 months ago (2015-09-29 13:14:31 UTC) #15
edwardjung
5 years, 2 months ago (2015-10-01 16:27:07 UTC) #16
Message was sent while issue was closed.
On 2015/09/29 13:14:31, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/51500bb57c4b7e26e48d87768da935bc432f6870
> Cr-Commit-Position: refs/heads/master@{#351302}

Jochen, would it be possible for you to help me do a cherry pick merge of this
CL to M46 branch (2490)
Commit id: 51500bb57c4b7e26e48d87768da935bc432f6870

I need someone with commit access. Thanks.

Powered by Google App Engine
This is Rietveld 408576698