Pinch/Zoom Infrastructure & Plumbing CL (Prequel)

Source/platform/graphics/GraphicsLayer.h

Index: Source/platform/graphics/GraphicsLayer.h
diff --git a/Source/platform/graphics/GraphicsLayer.h b/Source/platform/graphics/GraphicsLayer.h
index 8104292526ba4d7c8035fdfd14e93095cf29a10a..5d01af82932e944af0570c657643c12886841d9d 100644
--- a/Source/platform/graphics/GraphicsLayer.h
+++ b/Source/platform/graphics/GraphicsLayer.h
@@ -302,14 +302,14 @@ public:
     // WebLayerScrollClient implementation.
     virtual void didScroll() OVERRIDE;
 
+    // Exposed for use in PinchViewports.cpp.

[enne (OOO), 2014/01/14 22:43:55]

comment nit: I think this is a little over-specific and could probably be
removed.  What if some other site starts calling it?

[jamesr, 2014/01/14 22:48:58]

yeah, it doesn't make sense for a comment in /platform/ to talk about classes in
/web/.  Anyone with code search can find out what code is calling something.  If
this needs a comment (and I'm not sure that it does) then the comment needs to
explain the function in terms of concepts exposed in /platform/

It's pretty confusing that this interface has a contentLayer() and a
contentsLayer() that do different things

[wjmaclean, 2014/01/14 23:55:29]

Based on James' other comment, I have removed this change.

+    virtual blink::WebLayer* contentsLayer() const { return m_contentsLayer; }
+
 protected:
     explicit GraphicsLayer(GraphicsLayerClient*);
     // GraphicsLayerFactoryChromium that wants to create a GraphicsLayer need to be friends.
     friend class blink::GraphicsLayerFactoryChromium;
 
-    // Exposed for tests.
-    virtual blink::WebLayer* contentsLayer() const { return m_contentsLayer; }
-
 private:
     // Adds a child without calling updateChildList(), so that adding children
     // can be batched before updating.