Pinch/Zoom Infrastructure & Plumbing CL (Prequel)

Source/platform/graphics/GraphicsLayer.h

 /*
  * Copyright (C) 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Intel Corporation. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 284 matching lines @@
     // GraphicsContextPainter implementation.
     virtual void paint(GraphicsContext&, const IntRect& clip) OVERRIDE;
 
     // WebAnimationDelegate implementation.
     virtual void notifyAnimationStarted(double wallClockTime, double monotonicTime, blink::WebAnimation::TargetProperty) OVERRIDE;
     virtual void notifyAnimationFinished(double wallClockTime, double monotonicTime, blink::WebAnimation::TargetProperty) OVERRIDE;
 
     // WebLayerScrollClient implementation.
     virtual void didScroll() OVERRIDE;
 
+    // Exposed for use in PinchViewports.cpp.

[enne (OOO), 2014/01/14 22:43:55]

comment nit: I think this is a little over-specific and could probably be
removed.  What if some other site starts calling it?

[jamesr, 2014/01/14 22:48:58]

yeah, it doesn't make sense for a comment in /platform/ to talk about classes in
/web/.  Anyone with code search can find out what code is calling something.  If
this needs a comment (and I'm not sure that it does) then the comment needs to
explain the function in terms of concepts exposed in /platform/

It's pretty confusing that this interface has a contentLayer() and a
contentsLayer() that do different things

[wjmaclean, 2014/01/14 23:55:29]

Based on James' other comment, I have removed this change.

+    virtual blink::WebLayer* contentsLayer() const { return m_contentsLayer; }
+
 protected:
     explicit GraphicsLayer(GraphicsLayerClient*);
     // GraphicsLayerFactoryChromium that wants to create a GraphicsLayer need to be friends.
     friend class blink::GraphicsLayerFactoryChromium;
 
-    // Exposed for tests.
-    virtual blink::WebLayer* contentsLayer() const { return m_contentsLayer; }
-
 private:
     // Adds a child without calling updateChildList(), so that adding children
     // can be batched before updating.
     void addChildInternal(GraphicsLayer*);
 
     // This method is used by platform GraphicsLayer classes to clear the filters
     // when compositing is not done in hardware. It is not virtual, so the caller
     // needs to notifiy the change to the platform layer as needed.
     void clearFilters() { m_filters.clear(); }
 
@@ skipping 86 matching lines @@
 
 
 } // namespace WebCore
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showGraphicsLayerTree(const WebCore::GraphicsLayer* layer);
 #endif
 
 #endif // GraphicsLayer_h