chrome/browser/ui/cocoa/one_click_signin_view_controller.h - Issue 13845022: Mac: Display a native bubble (instead of the JS one) after the web signin flow. (branched from http…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_view_controller.h

Issue 13845022: Mac: Display a native bubble (instead of the JS one) after the web signin flow. (branched from http… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntpBubble

Patch Set: Fix bot issues Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm ('K') | « chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm ('k') | chrome/browser/ui/cocoa/one_click_signin_view_controller.mm » ('j') | chrome/browser/ui/cocoa/one_click_signin_view_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/one_click_signin_view_controller.h

diff --git a/chrome/browser/ui/cocoa/one_click_signin_view_controller.h b/chrome/browser/ui/cocoa/one_click_signin_view_controller.h

index c3d2ae76279f84e6ac9675d2447563b4cf4ddc67..11b054235c2e82d27d0774de5cf98ab060152c9b 100644

--- a/chrome/browser/ui/cocoa/one_click_signin_view_controller.h

+++ b/chrome/browser/ui/cocoa/one_click_signin_view_controller.h

@@ -25,6 +25,9 @@ class WebContents;

IBOutlet NSButton* advancedLink_;

IBOutlet NSButton* closeButton_;

+ bool isSyncDialog_;

+ NSString* errorMessage_;

// Text fields don't work as well with embedded links as text views, but

// text views cannot conveniently be created in IB. The xib file contains

// a text field |informativePlaceholderTextField_| that's replaced by this

@@ -38,7 +41,9 @@ class WebContents;

- (id)initWithNibName:(NSString*)nibName

Alexei Svitkine (slow) 2013/04/19 19:54:15 Please document these params.

noms (inactive) 2013/04/22 15:28:07 Done.

webContents:(content::WebContents*)webContents

syncCallback:(const BrowserWindow::StartSyncCallback&)syncCallback

- closeCallback:(const base::Closure&)callback;

+ closeCallback:(const base::Closure&)callback

+ isSyncDialog:(bool)isSyncDialog

Alexei Svitkine (slow) 2013/04/19 19:54:15 Use the Obj-C type BOOL (with values YES/NO) rathe

noms (inactive) 2013/04/22 15:28:07 Done.

+ errorMessage:(const string16&)errorMessage;

// Called before the view is closed.

- (void)viewWillClose;