chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm - Issue 13845022: Mac: Display a native bubble (instead of the JS one) after the web signin flow. (branched from http…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm

Issue 13845022: Mac: Display a native bubble (instead of the JS one) after the web signin flow. (branched from http… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ntpBubble

Patch Set: Fix bot issues Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/one_click_signin_bubble_controller.mm ('K') | « chrome/browser/ui/cocoa/one_click_signin_bubble_controller_unittest.mm ('k') | chrome/browser/ui/cocoa/one_click_signin_view_controller.h » ('j') | chrome/browser/ui/cocoa/one_click_signin_view_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm

diff --git a/chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm b/chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm

index 7e1f675266fef5a14ec89351a93eb894c8ede429..ed97bc9b3b90fcb3332193cf193be084b55bbbea 100644

--- a/chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm

+++ b/chrome/browser/ui/cocoa/one_click_signin_dialog_controller.mm

@@ -19,7 +19,9 @@ OneClickSigninDialogController::OneClickSigninDialogController(

initWithNibName:@"OneClickSigninDialog"

webContents:web_contents

syncCallback:sync_callback

- closeCallback:close_callback]);

+ closeCallback:close_callback

+ isSyncDialog:true

+ errorMessage:string16()]);

scoped_nsobject<NSWindow> window([[ConstrainedWindowCustomWindow alloc]

initWithContentRect:[[view_controller_ view] bounds]]);

[[window contentView] addSubview:[view_controller_ view]];