Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1384433002: distiller: Retires support of CreateNewContext. (Closed)

Created:
5 years, 2 months ago by Yuki
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

distiller: Retires support of CreateNewContext. The binding team in Blink is working to make the implementation of "window" JS object comformant to the web spec. Once it gets implemented correctly, you can no longer create a fake "window" object just by calling Object.create(window). Such a fake "window" object cannot pass our upcoming type check. Thus, this CL removes support of such a fake "window" object. WIP CL http://crrev.com/1380503002 requires this change. BUG=43394, 516274 TEST=Ran DomDistillerTabUtilsBrowserTest in browser_tests and DistillerPageWebContentsTest in components_browsertests. Committed: https://crrev.com/36b22ec535dfa52829d7e3651bf664ab416287ec Cr-Commit-Position: refs/heads/master@{#352294}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -46 lines) Patch
M components/dom_distiller/content/browser/distiller_page_web_contents.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/dom_distiller/content/browser/distiller_page_web_contents.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M components/dom_distiller/core/distiller_page.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/dom_distiller/core/distiller_page.cc View 3 chunks +2 lines, -14 lines 0 comments Download
M components/dom_distiller/core/fake_distiller_page.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/dom_distiller/core/javascript/domdistiller.js View 2 chunks +7 lines, -13 lines 0 comments Download
M components/dom_distiller/ios/distiller_page_ios.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/dom_distiller/ios/distiller_page_ios.mm View 1 2 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Yuki
Could you review this CL?
5 years, 2 months ago (2015-10-01 08:12:37 UTC) #2
nyquist
wychen and noyau: Could you two please take a look at this and how it ...
5 years, 2 months ago (2015-10-01 17:57:55 UTC) #4
noyau (Ping after 24h)
lgtm iOS lgtm
5 years, 2 months ago (2015-10-02 07:55:50 UTC) #5
wychen
lgtm
5 years, 2 months ago (2015-10-02 23:48:19 UTC) #6
nyquist
lgtm
5 years, 2 months ago (2015-10-03 00:15:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384433002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384433002/60001
5 years, 2 months ago (2015-10-05 03:57:28 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-05 04:51:08 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 04:52:09 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/36b22ec535dfa52829d7e3651bf664ab416287ec
Cr-Commit-Position: refs/heads/master@{#352294}

Powered by Google App Engine
This is Rietveld 408576698