Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: components/dom_distiller/ios/distiller_page_ios.mm

Issue 1384433002: distiller: Retires support of CreateNewContext. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Synced. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/dom_distiller/ios/distiller_page_ios.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/dom_distiller/ios/distiller_page_ios.mm
diff --git a/components/dom_distiller/ios/distiller_page_ios.mm b/components/dom_distiller/ios/distiller_page_ios.mm
index 8f2e29ddb1392982f24430fa4d675a1568c8d1a8..b0e9a6e945108f239b36a468b5b93516b0f0f590 100644
--- a/components/dom_distiller/ios/distiller_page_ios.mm
+++ b/components/dom_distiller/ios/distiller_page_ios.mm
@@ -56,14 +56,6 @@ bool DistillerPageIOS::StringifyOutput() {
return true;
}
-bool DistillerPageIOS::CreateNewContext() {
- // UIWebView's JavaScript engine has a bug that causes crashes when
- // creating a separate window object, so allow the script to run directly
- // in the window until a better solution is created.
- // TODO(kkhorimoto): investigate whether this is necessary for WKWebView.
- return false;
-}
-
void DistillerPageIOS::DistillPageImpl(const GURL& url,
const std::string& script) {
if (!url.is_valid() || !script.length())
« no previous file with comments | « components/dom_distiller/ios/distiller_page_ios.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698