Issue 13844009: Actually implement the sqrt intrinsic in Crankshaft

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13844009: Actually implement the sqrt intrinsic in Crankshaft (Closed)

Created:
7 years, 8 months ago by Sven Panne

Modified:
7 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev, tfarina

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Actually implement the sqrt intrinsic in Crankshaft Committed: http://code.google.com/p/v8/source/detail?r=14260

Patch Set 1 #

Total comments: 2

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/hydrogen.cc	View		1 chunk	+7 lines, -1 line	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

Committed patchset #1 manually as r14260 (presubmit successful).

7 years, 8 months ago (2013-04-15 10:36:20 UTC) #3

tfarina

https://codereview.chromium.org/13844009/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): https://codereview.chromium.org/13844009/diff/1/src/hydrogen.cc#newcode10974 src/hydrogen.cc:10974: return ast_context()->ReturnInstruction(result, call->id()); why you return here, if the ...

7 years, 8 months ago (2013-04-16 01:23:19 UTC) #4

Sven Panne

7 years, 8 months ago (2013-04-16 06:11:16 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/13844009/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/13844009/diff/1/src/hydrogen.cc#newcode10974
src/hydrogen.cc:10974: return ast_context()->ReturnInstruction(result,
call->id());
On 2013/04/16 01:23:19, tfarina wrote:
> why you return here, if the return type of GenerateMathSqrt is void?

There is no deep reason, just for consistency with the other GenerateFoo
functions in the vicinity. OTOH, in C++ 'void' is not really special (because of
templates), and this is a good thing IMHO: 'void' is just another type with a
single value, just like Haskell's 0-tuple '()'.

Expand Messages | Collapse Messages