Actually implement the sqrt intrinsic in Crankshaft

src/hydrogen.cc

Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index a2ddc04b9174f2ec7b95f68acd3acd199ee0a848..ab1428e303bfb25f1ee51e2650898689ca6db258 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -10965,7 +10965,13 @@ void HOptimizedGraphBuilder::GenerateMathLog(CallRuntime* call) {
 
 
 void HOptimizedGraphBuilder::GenerateMathSqrt(CallRuntime* call) {
-  return Bailout("inlined runtime function: MathSqrt");
+  ASSERT(call->arguments()->length() == 1);
+  CHECK_ALIVE(VisitForValue(call->arguments()->at(0)));
+  HValue* value = Pop();
+  HValue* context = environment()->LookupContext();
+  HInstruction* result =
+      HUnaryMathOperation::New(zone(), context, value, kMathSqrt);
+  return ast_context()->ReturnInstruction(result, call->id());

[tfarina, 2013/04/16 01:23:19]

why you return here, if the return type of GenerateMathSqrt is void?

[Sven Panne, 2013/04/16 06:11:16]

There is no deep reason, just for consistency with the other GenerateFoo
functions in the vicinity. OTOH, in C++ 'void' is not really special (because of
templates), and this is a good thing IMHO: 'void' is just another type with a
single value, just like Haskell's 0-tuple '()'.

 }