Issue 1384383002: Revert of browser test for kAccountsPrefAllowNewUser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1384383002: Revert of browser test for kAccountsPrefAllowNewUser. (Closed)

Created:
5 years, 2 months ago by maniscalco

Modified:
5 years, 2 months ago

Reviewers:
bartfab (slow), jdufault, achuithb

CC:
chromium-reviews, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of browser test for kAccountsPrefAllowNewUser. (patchset #1 id:1 of https://codereview.chromium.org/1386523002/ ) Reason for revert: Suspected as cause of test failure on chromium.memory.fyi. For details see https://code.google.com/p/chromium/issues/detail?id=539588 Original issue's description: > browser test for kAccountsPrefAllowNewUser. > > BUG=528265 > TEST=this is the test. > > Committed: https://crrev.com/fa4ec1333e7139ce7d4deee4f65edc5a638575d3 > Cr-Commit-Position: refs/heads/master@{#352366} TBR=bartfab@chromium.org,jdufault@chromium.org,achuith@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=528265 Committed: https://crrev.com/89b8f7d311f6616a7371b977ae0e7184151214df Cr-Commit-Position: refs/heads/master@{#352440}

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -23 lines)			Patch
M	chrome/browser/chromeos/login/test/oobe_base_test.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/test/oobe_base_test.cc	View	1 chunk	+1 line, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/webview_login_browsertest.cc	View	1 chunk	+1 line, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

maniscalco

Created Revert of browser test for kAccountsPrefAllowNewUser.

5 years, 2 months ago (2015-10-05 22:01:12 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1384383002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1384383002/1

5 years, 2 months ago (2015-10-05 22:04:50 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-10-05 22:09:37 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/89b8f7d311f6616a7371b977ae0e7184151214df
Cr-Commit-Position: refs/heads/master@{#352440}

Expand Messages | Collapse Messages