Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Unified Diff: chrome/browser/chromeos/login/webview_login_browsertest.cc

Issue 1384383002: Revert of browser test for kAccountsPrefAllowNewUser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/test/oobe_base_test.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/webview_login_browsertest.cc
diff --git a/chrome/browser/chromeos/login/webview_login_browsertest.cc b/chrome/browser/chromeos/login/webview_login_browsertest.cc
index 9254b86a7bcbb0e6cba83de38d80cc4c4c585a4b..520538ae22fd67889583d8c8513214cd0ed3cd7f 100644
--- a/chrome/browser/chromeos/login/webview_login_browsertest.cc
+++ b/chrome/browser/chromeos/login/webview_login_browsertest.cc
@@ -83,25 +83,8 @@
IN_PROC_BROWSER_TEST_F(WebviewLoginTest, AllowGuest) {
WaitForGaiaPageLoad();
JsExpect("!$('guest-user-header-bar-item').hidden");
- CrosSettings::Get()->SetBoolean(kAccountsPrefAllowGuest, false);
+ chromeos::CrosSettings::Get()->SetBoolean(kAccountsPrefAllowGuest, false);
JsExpect("$('guest-user-header-bar-item').hidden");
}
-// Create new account option should be available only if the settings allow it.
-IN_PROC_BROWSER_TEST_F(WebviewLoginTest, AllowNewUser) {
- WaitForGaiaPageLoad();
-
- std::string frame_url = "$('gaia-signin').gaiaAuthHost_.initialFrameUrl_";
- // New users are allowed.
- JsExpect(frame_url + ".search('flow=nosignup') == -1");
-
- // Disallow new users - we also need to set a whitelist due to weird logic.
- CrosSettings::Get()->Set(kAccountsPrefUsers, base::ListValue());
- CrosSettings::Get()->SetBoolean(kAccountsPrefAllowNewUser, false);
- WaitForGaiaPageReload();
-
- // flow=nosignup indicates that user creation is not allowed.
- JsExpect(frame_url + ".search('flow=nosignup') != -1");
-}
-
} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/login/test/oobe_base_test.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698