Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: net/third_party/nss/ssl/ssl3con.c

Issue 13843023: Use CERT_GetCertKeyType to get KeyType for ssl3_PlatformSignHashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/third_party/nss/ssl/sslimpl.h » ('j') | net/third_party/nss/ssl/sslplatf.c » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/third_party/nss/ssl/ssl3con.c
diff --git a/net/third_party/nss/ssl/ssl3con.c b/net/third_party/nss/ssl/ssl3con.c
index 18ed5395c8ff674d4d1a92f3cf87fe865f85a56e..2872d785b7c5c37b44ddd348ea0bcf0ba3f846e7 100644
--- a/net/third_party/nss/ssl/ssl3con.c
+++ b/net/third_party/nss/ssl/ssl3con.c
@@ -5366,7 +5366,8 @@ ssl3_SendCertificateVerify(sslSocket *ss)
if (ss->ssl3.platformClientKey) {
#ifdef NSS_PLATFORM_CLIENT_AUTH
rv = ssl3_PlatformSignHashes(&hashes, ss->ssl3.platformClientKey,
- &buf, isTLS);
+ &buf, isTLS, CERT_GetCertKeyType(
+ &ss->ssl3.clientCertificate->subjectPublicKeyInfo));
Ryan Sleevi 2013/04/25 18:37:42 Looks like this function uses four tabs to indent,
wtc 2013/04/25 19:10:17 For NSS files, set the tabstop to 8 (as opposed to
mef 2013/04/25 19:31:15 Is there 80 column limit on line length? On 2013/0
mef 2013/04/25 19:31:15 Done.
wtc 2013/04/25 19:57:24 Yes, the same 80 column limit is used in NSS files
ssl_FreePlatformKey(ss->ssl3.platformClientKey);
ss->ssl3.platformClientKey = (PlatformKey)NULL;
#endif /* NSS_PLATFORM_CLIENT_AUTH */
« no previous file with comments | « no previous file | net/third_party/nss/ssl/sslimpl.h » ('j') | net/third_party/nss/ssl/sslplatf.c » ('J')

Powered by Google App Engine
This is Rietveld 408576698