Use CERT_GetCertKeyType to get KeyType for ssl3_PlatformSignHashes.

net/third_party/nss/ssl/ssl3con.c

 /* -*- Mode: C; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
 /*
  * SSL3 Protocol
  *
  * This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
 /* $Id: ssl3con.c,v 1.192 2012/09/28 05:10:25 wtc%google.com Exp $ */
 
 /* TODO(ekr): Implement HelloVerifyRequest on server side. OK for now. */
@@ skipping 5348 matching lines @@
     rv = ssl3_ComputeHandshakeHashes(ss, ss->ssl3.pwSpec, &hashes, 0);
     ssl_ReleaseSpecReadLock(ss);
     if (rv != SECSuccess) {
         goto done;      /* err code was set by ssl3_ComputeHandshakeHashes */
     }
 
     isTLS = (PRBool)(ss->ssl3.pwSpec->version > SSL_LIBRARY_VERSION_3_0);
     if (ss->ssl3.platformClientKey) {
 #ifdef NSS_PLATFORM_CLIENT_AUTH
         rv = ssl3_PlatformSignHashes(&hashes, ss->ssl3.platformClientKey,
-                                     &buf, isTLS);
+                                     &buf, isTLS, CERT_GetCertKeyType(
+                                                &ss->ssl3.clientCertificate->subjectPublicKeyInfo));

[Ryan Sleevi, 2013/04/25 18:37:42]

Looks like this function uses four tabs to indent, and then covers the remaining
with spaces.

[wtc, 2013/04/25 19:10:17]

For NSS files, set the tabstop to 8 (as opposed to 2 or 4).

[mef, 2013/04/25 19:31:15]

Is there 80 column limit on line length?
On 2013/04/25 19:10:17, wtc wrote:

[mef, 2013/04/25 19:31:15]

Done.

[wtc, 2013/04/25 19:57:24]

Yes, the same 80 column limit is used in NSS files.

         ssl_FreePlatformKey(ss->ssl3.platformClientKey);
         ss->ssl3.platformClientKey = (PlatformKey)NULL;
 #endif /* NSS_PLATFORM_CLIENT_AUTH */
     } else {
         rv = ssl3_SignHashes(&hashes, ss->ssl3.clientPrivateKey, &buf, isTLS);
         if (rv == SECSuccess) {
             PK11SlotInfo * slot;
             sslSessionID * sid   = ss->sec.ci.sid;
 
             /* Remember the info about the slot that did the signing.
@@ skipping 5892 matching lines @@
             PORT_Free(ss->ssl3.hs.recvdFragments.buf);
         }
     }
 
     ss->ssl3.initialized = PR_FALSE;
 
     SECITEM_FreeItem(&ss->ssl3.nextProto, PR_FALSE);
 }
 
 /* End of ssl3con.c */