Issue 13843022: Fix generator suspend and resume on ARM

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13843022: Fix generator suspend and resume on ARM (Closed)

Created:
7 years, 8 months ago by wingo

Modified:
7 years, 8 months ago

Reviewers:
Michael Starzinger

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Fix generator suspend and resume on ARM This CL fixes a number of rookie mistakes in FullCodeGenerator::VisitYield and FullCodeGenerator::EmitGeneratorResume, and re-enables the generators-iteration test on ARM. R=mstarzinger@chromium.org BUG=v8:2355 TEST=mjsunit/harmony/generators-iteration Committed: http://code.google.com/p/v8/source/detail?r=14424

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	M	src/arm/full-codegen-arm.cc	View		3 chunks	+6 lines, -5 lines	0 comments	Download
	M	test/mjsunit/mjsunit.status	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

7 years, 8 months ago (2013-04-24 16:07:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r14424 (presubmit successful).

Expand Messages | Collapse Messages