Fix generator suspend and resume on ARM

src/arm/full-codegen-arm.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1984 matching lines @@
   __ b(le, &wrong_state);
 
   // Load suspended function and context.
   __ ldr(cp, FieldMemOperand(r1, JSGeneratorObject::kContextOffset));
   __ ldr(r4, FieldMemOperand(r1, JSGeneratorObject::kFunctionOffset));
 
   // Push holes for arguments to generator function.
   __ ldr(r3, FieldMemOperand(r4, JSFunction::kSharedFunctionInfoOffset));
   __ ldr(r3,
          FieldMemOperand(r3, SharedFunctionInfo::kFormalParameterCountOffset));
-  __ Move(r2, isolate()->factory()->the_hole_value());
+  __ LoadRoot(r2, Heap::kTheHoleValueRootIndex);
   Label push_argument_holes;
   __ bind(&push_argument_holes);
   __ push(r2);
-  __ sub(r3, r3, Operand(1));
-  __ b(vc, &push_argument_holes);
+  __ sub(r3, r3, Operand(1), SetCC);
+  __ b(pl, &push_argument_holes);
 
   // Enter a new JavaScript frame, and initialize its slots as they were when
   // the generator was suspended.
   Label push_frame, resume_frame;
   __ bind(&push_frame);
   __ bl(&resume_frame);
   __ jmp(&done);
   __ bind(&resume_frame);
+  __ push(lr);  // Return address.
   __ push(fp);  // Caller's frame pointer.
   __ mov(fp, sp);
   __ push(cp);  // Callee's context.
   __ push(r4);  // Callee's JS Function.
 
   // Load the operand stack size.
   __ ldr(r3, FieldMemOperand(r1, JSGeneratorObject::kOperandStackOffset));
   __ ldr(r3, FieldMemOperand(r3, FixedArray::kLengthOffset));
   __ SmiUntag(r3);
 
@@ skipping 10 matching lines @@
     __ mov(r2, Operand(Smi::FromInt(JSGeneratorObject::kGeneratorExecuting)));
     __ str(r2, FieldMemOperand(r1, JSGeneratorObject::kContinuationOffset));
     __ Jump(r3);
     __ bind(&slow_resume);
   }
 
   // Otherwise, we push holes for the operand stack and call the runtime to fix
   // up the stack and the handlers.
   Label push_operand_holes, call_resume;
   __ bind(&push_operand_holes);
-  __ sub(r3, r3, Operand(1));
-  __ b(vs, &call_resume);
+  __ sub(r3, r3, Operand(1), SetCC);
+  __ b(mi, &call_resume);
   __ push(r2);
   __ b(&push_operand_holes);
   __ bind(&call_resume);
   __ push(r1);
   __ push(result_register());
   __ Push(Smi::FromInt(resume_mode));
   __ CallRuntime(Runtime::kResumeJSGeneratorObject, 3);
   // Not reached: the runtime call returns elsewhere.
   __ stop("not-reached");
 
@@ skipping 2635 matching lines @@
   *context_length = 0;
   return previous_;
 }
 
 
 #undef __
 
 } }  // namespace v8::internal
 
 #endif  // V8_TARGET_ARCH_ARM