Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: third_party/WebKit/public/platform/WebGraphicsContext3D.h

Issue 1384233003: Improve usefulness of webglcontextcreationerror statusMessage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/public/platform/WebGraphicsContext3D.h
diff --git a/third_party/WebKit/public/platform/WebGraphicsContext3D.h b/third_party/WebKit/public/platform/WebGraphicsContext3D.h
index 7fb30ca84966e4e8d33a94de1554ecab0075d515..1db27089a5ce071ba45fcd6f327282cf12c8c30e 100644
--- a/third_party/WebKit/public/platform/WebGraphicsContext3D.h
+++ b/third_party/WebKit/public/platform/WebGraphicsContext3D.h
@@ -63,15 +63,6 @@ typedef struct __WGC3Dsync *WGC3Dsync;
// Typedef for server-side objects like OpenGL textures and program objects.
typedef WGC3Duint WebGLId;
-struct WebGLInfo {
- WGC3Duint vendorId;
- WGC3Duint deviceId;
- WebString vendorInfo;
- WebString rendererInfo;
- WebString driverVersion;
- WebString contextInfoCollectionFailure;
-};
-
// This interface abstracts the operations performed by the
// GraphicsContext3D in order to implement WebGL. Nearly all of the
// methods exposed on this interface map directly to entry points in
@@ -123,6 +114,33 @@ public:
WebString topDocumentURL;
};
+ struct WebGraphicsContext3DInfo {
+ WebGraphicsContext3DInfo()
+ : vendorId(0)
+ , deviceId(0)
+ , processCrashCount(0)
+ , resetNotificationStrategy(false)
+ , sandboxed(false)
+ , lenovoDcute(false)
+ , testFailContext(false)
+ {
+ }
+ unsigned vendorId;
+ unsigned deviceId;
+ unsigned processCrashCount;
+ bool resetNotificationStrategy;
+ bool sandboxed;
+ bool lenovoDcute;
Ken Russell (switch to Gerrit) 2015/10/12 23:52:42 I think the lenovoDcute flag doesn't provide any u
sivag 2015/10/15 17:16:38 Done.
+ bool amdSwitchable;
+ bool optimus;
+ WebString vendorInfo;
+ WebString rendererInfo;
+ WebString driverVersion;
+ WebString errorMessage;
+ WebString displayLinkVersion;
Ken Russell (switch to Gerrit) 2015/10/12 23:52:43 Similarly for the displayLinkVersion.
sivag 2015/10/15 17:16:38 Done.
+ bool testFailContext;
+ };
+
class WebGraphicsContextLostCallback {
public:
virtual void onContextLost() = 0;

Powered by Google App Engine
This is Rietveld 408576698