Improve usefulness of webglcontextcreationerror statusMessage

third_party/WebKit/public/platform/WebGraphicsContext3D.h

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 45 matching lines @@
 typedef float WGC3Dclampf;
 typedef signed long int WGC3Dintptr;
 typedef signed long int WGC3Dsizeiptr;
 typedef int64_t WGC3Dint64;
 typedef uint64_t WGC3Duint64;
 typedef struct __WGC3Dsync *WGC3Dsync;
 
 // Typedef for server-side objects like OpenGL textures and program objects.
 typedef WGC3Duint WebGLId;
 
-struct WebGLInfo {
-    WGC3Duint vendorId;
-    WGC3Duint deviceId;
-    WebString vendorInfo;
-    WebString rendererInfo;
-    WebString driverVersion;
-    WebString contextInfoCollectionFailure;
-};
-
 // This interface abstracts the operations performed by the
 // GraphicsContext3D in order to implement WebGL. Nearly all of the
 // methods exposed on this interface map directly to entry points in
 // the OpenGL ES 2.0 API.
 class WebGraphicsContext3D : public WebNonCopyable {
 public:
     // Return value from getActiveUniform and getActiveAttrib.
     struct ActiveInfo {
         WebString name;
         WGC3Denum type;
@@ skipping 31 matching lines @@
         bool noAutomaticFlushes;
         bool failIfMajorPerformanceCaveat;
         bool webGL;
         unsigned webGLVersion;
         // FIXME: ideally this would be a WebURL, but it is currently not
         // possible to pass a WebURL by value across the WebKit API boundary.
         // See https://bugs.webkit.org/show_bug.cgi?id=103793#c13 .
         WebString topDocumentURL;
     };
 
+    struct WebGraphicsContext3DInfo {
+        WebGraphicsContext3DInfo()
+            : vendorId(0)
+            , deviceId(0)
+            , processCrashCount(0)
+            , resetNotificationStrategy(false)
+            , sandboxed(false)
+            , lenovoDcute(false)
+            , testFailContext(false)
+        {
+        }
+        unsigned vendorId;
+        unsigned deviceId;
+        unsigned processCrashCount;
+        bool resetNotificationStrategy;
+        bool sandboxed;
+        bool lenovoDcute;

[Ken Russell (switch to Gerrit), 2015/10/12 23:52:42]

I think the lenovoDcute flag doesn't provide any useful information and could be
removed.

[sivag, 2015/10/15 17:16:38]

Done.

+        bool amdSwitchable;
+        bool optimus;
+        WebString vendorInfo;
+        WebString rendererInfo;
+        WebString driverVersion;
+        WebString errorMessage;
+        WebString displayLinkVersion;

[Ken Russell (switch to Gerrit), 2015/10/12 23:52:43]

Similarly for the displayLinkVersion.

[sivag, 2015/10/15 17:16:38]

Done.

+        bool testFailContext;
+    };
+
     class WebGraphicsContextLostCallback {
     public:
         virtual void onContextLost() = 0;
 
     protected:
         virtual ~WebGraphicsContextLostCallback() { }
     };
 
     class WebGraphicsErrorMessageCallback {
     public:
@@ skipping 424 matching lines @@
     virtual void vertexAttribI4iv(WGC3Duint index, const WGC3Dint *v) { }
     virtual void vertexAttribI4ui(WGC3Duint index, WGC3Duint x, WGC3Duint y, WGC3Duint z, WGC3Duint w) { }
     virtual void vertexAttribI4uiv(WGC3Duint index, const WGC3Duint *v) { }
     virtual void vertexAttribIPointer(WGC3Duint index, WGC3Dint size, WGC3Denum type, WGC3Dsizei stride, WGC3Dintptr pointer) { }
     virtual void waitSync(WGC3Dsync sync, WGC3Dbitfield flags, WGC3Duint64 timeout) { }
 };
 
 } // namespace blink
 
 #endif