Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: net/http/http_auth_handler_basic_unittest.cc

Issue 1383613002: [net/http auth] Cleanup. Method names, and constness. Base URL: https://chromium.googlesource.com/chromium/src.git@mock-auth-handler-generalization
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/http/http_auth_handler_basic.cc ('k') | net/http/http_auth_handler_digest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/http/http_auth_handler_basic_unittest.cc
diff --git a/net/http/http_auth_handler_basic_unittest.cc b/net/http/http_auth_handler_basic_unittest.cc
index 60e588291ca1fab44a2b9278e74932c2feff1c73..de173cb0b64db7a06110ebed8fb8f9d5a2c3b6c5 100644
--- a/net/http/http_auth_handler_basic_unittest.cc
+++ b/net/http/http_auth_handler_basic_unittest.cc
@@ -43,7 +43,7 @@ TEST(HttpAuthHandlerBasicTest, GenerateAuthToken) {
HttpRequestInfo request_info;
std::string auth_token;
TestCompletionCallback callback;
- int rv = basic->GenerateAuthToken(&credentials, &request_info,
+ int rv = basic->GenerateAuthToken(&credentials, request_info,
callback.callback(), &auth_token);
EXPECT_EQ(OK, rv);
EXPECT_STREQ(tests[i].expected_credentials, auth_token.c_str());
@@ -96,11 +96,11 @@ TEST(HttpAuthHandlerBasicTest, HandleAnotherChallenge) {
std::string challenge(tests[i].challenge);
HttpAuthChallengeTokenizer tok(challenge.begin(),
challenge.end());
- EXPECT_EQ(tests[i].expected_rv, basic->HandleAnotherChallenge(&tok));
+ EXPECT_EQ(tests[i].expected_rv, basic->HandleAnotherChallenge(tok));
}
}
-TEST(HttpAuthHandlerBasicTest, InitFromChallenge) {
+TEST(HttpAuthHandlerBasicTest, HandleInitialChallenge) {
static const struct {
const char* challenge;
int expected_rv;
« no previous file with comments | « net/http/http_auth_handler_basic.cc ('k') | net/http/http_auth_handler_digest.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698