Fix array out of bounds access in loop iteration in gpu ipc log

Fix array out of bounds access in loop iteration in gpu ipc log

gpu::ValueState is defined as a union of an array of int_value or float_value.
sizeof(ValueState.{int_value|float_value}) will return the size as
atleast 16, since both the arrays are defined to be of size 4.

Using the sizeof() value, the ::Log() tries to iterate from 0 to 15, through
the array bounds are from 0 to 3.

BUG=None
TEST=None

Committed: https://crrev.com/070f79ff630ffc5d84c3218d274dc5bf8b023d67
Cr-Commit-Position: refs/heads/master@{#353242}

[RaviKasibhatla, 2015-10-06 10:34:25]

kphanee@chromium.org changed reviewers:
+ piman@chromium.org

[RaviKasibhatla, 2015-10-06 10:34:35]

kphanee@chromium.org changed reviewers:
+ kphanee@chromium.org

[RaviKasibhatla, 2015-10-06 10:34:36]

PTAL.

[piman, 2015-10-06 20:04:45]

https://codereview.chromium.org/1383463005/diff/1/gpu/ipc/gpu_command_buffer_...
File gpu/ipc/gpu_command_buffer_traits.cc (right):

https://codereview.chromium.org/1383463005/diff/1/gpu/ipc/gpu_command_buffer_...
gpu/ipc/gpu_command_buffer_traits.cc:118: for (size_t i = 0; i <
sizeof(p.int_value) / sizeof(p.int_value[0]); ++i)
nit: Can you use arraysize here?
Or even better use range for:
for (int value : p.int_value)
  *l += base::StringPrintf("%i ", value);

https://codereview.chromium.org/1383463005/diff/1/gpu/ipc/gpu_command_buffer_...
gpu/ipc/gpu_command_buffer_traits.cc:121: for (size_t i = 0; i <
sizeof(p.float_value) / sizeof(p.float_value[0]); ++i)
nit: same here.

[RaviKasibhatla, 2015-10-07 11:58:34]

Moved to the range syntax as suggested.

https://codereview.chromium.org/1383463005/diff/1/gpu/ipc/gpu_command_buffer_...
File gpu/ipc/gpu_command_buffer_traits.cc (right):

https://codereview.chromium.org/1383463005/diff/1/gpu/ipc/gpu_command_buffer_...
gpu/ipc/gpu_command_buffer_traits.cc:118: for (size_t i = 0; i <
sizeof(p.int_value) / sizeof(p.int_value[0]); ++i)
On 2015/10/06 20:04:45, piman (slow to review) wrote:
> nit: Can you use arraysize here?
> Or even better use range for:
> for (int value : p.int_value)
>   *l += base::StringPrintf("%i ", value);

Done.

https://codereview.chromium.org/1383463005/diff/1/gpu/ipc/gpu_command_buffer_...
gpu/ipc/gpu_command_buffer_traits.cc:121: for (size_t i = 0; i <
sizeof(p.float_value) / sizeof(p.float_value[0]); ++i)
On 2015/10/06 20:04:45, piman (slow to review) wrote:
> nit: same here.

Done.

[piman, 2015-10-08 22:09:17]

lgtm

[r.kasibhatla, 2015-10-09 04:44:48]

The CQ bit was checked by r.kasibhatla@samsung.com

[commit-bot: I haz the power, 2015-10-09 04:44:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1383463005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1383463005/20001

[commit-bot: I haz the power, 2015-10-09 07:17:21]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-09 07:18:42]

Patchset 2 (id:??) landed as
https://crrev.com/070f79ff630ffc5d84c3218d274dc5bf8b023d67
Cr-Commit-Position: refs/heads/master@{#353242}