Fix array out of bounds access in loop iteration in gpu ipc log

gpu/ipc/gpu_command_buffer_traits.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/ipc/gpu_command_buffer_traits.h"
 
 #include "gpu/command_buffer/common/mailbox_holder.h"
 #include "gpu/command_buffer/common/value_state.h"
 
 // Generate param traits write methods.
@@ skipping 97 matching lines @@
   const char* data = NULL;
   if (!iter->ReadData(&data, &length) || length != sizeof(gpu::ValueState))
     return false;
   DCHECK(data);
   memcpy(p, data, sizeof(gpu::ValueState));
   return true;
 }
 
 void ParamTraits<gpu::ValueState>::Log(const param_type& p, std::string* l) {
   l->append("<ValueState (");
-  for (size_t i = 0; i < sizeof(p.int_value); ++i)
+  for (size_t i = 0; i < sizeof(p.int_value) / sizeof(p.int_value[0]); ++i)

[piman, 2015/10/06 20:04:45]

nit: Can you use arraysize here?
Or even better use range for:
for (int value : p.int_value)
  *l += base::StringPrintf("%i ", value);

[RaviKasibhatla, 2015/10/07 11:58:34]

Done.

     *l += base::StringPrintf("%i ", p.int_value[i]);
   l->append(" int values ");
-  for (size_t i = 0; i < sizeof(p.float_value); ++i)
+  for (size_t i = 0; i < sizeof(p.float_value) / sizeof(p.float_value[0]); ++i)

[piman, 2015/10/06 20:04:45]

nit: same here.

[RaviKasibhatla, 2015/10/07 11:58:33]

Done.

     *l += base::StringPrintf("%f ", p.float_value[i]);
   l->append(" float values)>");
 }
 
 }  // namespace IPC