Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 138343007: Use more consistent naming for caching methods in NodeListsNodeData class (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Use more consistent naming for caching methods in NodeListsNodeData class All the caching methods are now called addCache() / removeCache() / cached() and overloading is used. The naming used to be a bit confusing, especially for the addCacheWithAtomicName() method which was not taking an AtomicString in argument. R=eseidel, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166869

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -34 lines) Patch
M Source/core/dom/ClassCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/ContainerNode.cpp View 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/Document.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/dom/Element.cpp View 2 chunks +5 lines, -6 lines 0 comments Download
M Source/core/dom/NameNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/NodeRareData.h View 1 2 5 chunks +6 lines, -7 lines 0 comments Download
M Source/core/dom/TagCollection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLNameCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LabelableElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LabelsNodeList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LabelsNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RadioNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
6 years, 10 months ago (2014-02-07 23:52:47 UTC) #1
adamk
lgtm
6 years, 10 months ago (2014-02-10 22:12:54 UTC) #2
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 10 months ago (2014-02-10 22:14:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/138343007/120001
6 years, 10 months ago (2014-02-10 22:14:30 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 23:01:49 UTC) #5
Message was sent while issue was closed.
Change committed as 166869

Powered by Google App Engine
This is Rietveld 408576698