Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Side by Side Diff: Source/core/dom/TagCollection.cpp

Issue 138343007: Use more consistent naming for caching methods in NodeListsNodeData class (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/dom/NodeRareData.h ('k') | Source/core/html/HTMLCollection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 22 matching lines...) Expand all
33 : HTMLCollection(rootNode, type, DoesNotOverrideItemAfter) 33 : HTMLCollection(rootNode, type, DoesNotOverrideItemAfter)
34 , m_namespaceURI(namespaceURI) 34 , m_namespaceURI(namespaceURI)
35 , m_localName(localName) 35 , m_localName(localName)
36 { 36 {
37 ASSERT(m_namespaceURI.isNull() || !m_namespaceURI.isEmpty()); 37 ASSERT(m_namespaceURI.isNull() || !m_namespaceURI.isEmpty());
38 } 38 }
39 39
40 TagCollection::~TagCollection() 40 TagCollection::~TagCollection()
41 { 41 {
42 if (m_namespaceURI == starAtom) 42 if (m_namespaceURI == starAtom)
43 ownerNode()->nodeLists()->removeCacheWithAtomicName(this, type(), m_loca lName); 43 ownerNode()->nodeLists()->removeCache(this, type(), m_localName);
44 else 44 else
45 ownerNode()->nodeLists()->removeCacheWithQualifiedName(this, m_namespace URI, m_localName); 45 ownerNode()->nodeLists()->removeCache(this, m_namespaceURI, m_localName) ;
46 } 46 }
47 47
48 bool TagCollection::elementMatches(const Element& testNode) const 48 bool TagCollection::elementMatches(const Element& testNode) const
49 { 49 {
50 // Implements http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#conce pt-getelementsbytagnamens 50 // Implements http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#conce pt-getelementsbytagnamens
51 if (m_localName != starAtom && m_localName != testNode.localName()) 51 if (m_localName != starAtom && m_localName != testNode.localName())
52 return false; 52 return false;
53 53
54 return m_namespaceURI == starAtom || m_namespaceURI == testNode.namespaceURI (); 54 return m_namespaceURI == starAtom || m_namespaceURI == testNode.namespaceURI ();
55 } 55 }
56 56
57 HTMLTagCollection::HTMLTagCollection(ContainerNode* rootNode, const AtomicString & localName) 57 HTMLTagCollection::HTMLTagCollection(ContainerNode* rootNode, const AtomicString & localName)
58 : TagCollection(rootNode, HTMLTagCollectionType, starAtom, localName) 58 : TagCollection(rootNode, HTMLTagCollectionType, starAtom, localName)
59 , m_loweredLocalName(localName.lower()) 59 , m_loweredLocalName(localName.lower())
60 { 60 {
61 } 61 }
62 62
63 } // namespace WebCore 63 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/NodeRareData.h ('k') | Source/core/html/HTMLCollection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698