Issue 138333006: Now that RenderFrame is 1:1 with WebFrame, add the associated getters and start cleaning up assumpt…

Issue 138333006: Now that RenderFrame is 1:1 with WebFrame, add the associated getters and start cleaning up assumpt… (Closed)

Created:
6 years, 11 months ago by jam

Modified:
6 years, 11 months ago

Reviewers:
boliu, nasko

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jochen+watch_chromium.org, site-isolation-reviews_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Now that RenderFrame is 1:1 with WebFrame, add the associated getters and start cleaning up assumptions. BUG=304341 R=nasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244842

Patch Set 4 : #

Total comments: 2

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -81 lines)			Patch
M	android_webview/renderer/aw_permission_client.h	View	1 2 3	1 chunk	+0 lines, -3 lines	2 comments	Download
M	android_webview/renderer/aw_permission_client.cc	View	1 2 3	2 chunks	+3 lines, -5 lines	0 comments	Download
M	chrome/renderer/content_settings_observer.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/content_settings_observer.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	content/public/renderer/render_frame.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	content/public/renderer/render_frame_observer.h	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	content/renderer/render_frame_impl.h	View		4 chunks	+5 lines, -14 lines	0 comments	Download
M	content/renderer/render_frame_impl.cc	View	1 2	5 chunks	+26 lines, -27 lines	0 comments	Download
M	content/renderer/render_view_impl.cc	View		4 chunks	+3 lines, -4 lines	0 comments	Download
M	content/renderer/shared_worker_repository.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/renderer/shared_worker_repository.cc	View		1 chunk	+1 line, -4 lines	0 comments	Download
M	content/shell/renderer/shell_render_frame_observer.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/shell/renderer/shell_render_frame_observer.cc	View	1	2 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

boliu

aw lgtm https://codereview.chromium.org/138333006/diff/750005/android_webview/renderer/aw_permission_client.h File android_webview/renderer/aw_permission_client.h (right): https://codereview.chromium.org/138333006/diff/750005/android_webview/renderer/aw_permission_client.h#newcode14 android_webview/renderer/aw_permission_client.h:14: class AwPermissionClient : public content::RenderFrameObserver, This is ...

6 years, 11 months ago (2014-01-15 18:12:46 UTC) #4

jam

6 years, 11 months ago (2014-01-16 16:29:08 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/138333006/diff/750005/android_webview/rendere...
File android_webview/renderer/aw_permission_client.h (right):

https://codereview.chromium.org/138333006/diff/750005/android_webview/rendere...
android_webview/renderer/aw_permission_client.h:14: class AwPermissionClient :
public content::RenderFrameObserver,
On 2014/01/15 18:12:46, boliu wrote:
> This is implementing RenderFrameObserver only so it can be deleted when
> RenderFrame goes away. Seems somewhat overkill...

we do have other observers like this. i think trying to optimize this further
depends on having some data that this is too costly

Expand Messages | Collapse Messages