Now that RenderFrame is 1:1 with WebFrame, add the associated getters and start cleaning up assumpt…

android_webview/renderer/aw_permission_client.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ANDROID_WEBVIEW_RENDERER_AW_PERMISSION_CLIENT_H_
 #define ANDROID_WEBVIEW_RENDERER_AW_PERMISSION_CLIENT_H_
 
 #include "content/public/renderer/render_frame_observer.h"
 #include "third_party/WebKit/public/web/WebPermissionClient.h"
 
 namespace android_webview {
 
 // Android WebView implementation of blink::WebPermissionClient.
 class AwPermissionClient : public content::RenderFrameObserver,

[boliu, 2014/01/15 18:12:46]

This is implementing RenderFrameObserver only so it can be deleted when
RenderFrame goes away. Seems somewhat overkill...

[jam, 2014/01/16 16:29:08]

we do have other observers like this. i think trying to optimize this further
depends on having some data that this is too costly

                            public blink::WebPermissionClient {
  public:
   explicit AwPermissionClient(content::RenderFrame* render_view);
 
  private:  
   virtual ~AwPermissionClient();
 
-  // content::RenderFrameObserver implementation.
-  virtual void WebFrameCreated(blink::WebFrame* frame) OVERRIDE;
-
   // blink::WebPermissionClient implementation.
   virtual bool allowDisplayingInsecureContent(
       blink::WebFrame* frame,
       bool enabled_per_settings,
       const blink::WebSecurityOrigin& origin,
       const blink::WebURL& url) OVERRIDE;
   virtual bool allowRunningInsecureContent(
       blink::WebFrame* frame,
       bool enabled_per_settings,
       const blink::WebSecurityOrigin& origin,
       const blink::WebURL& url) OVERRIDE;
 
   DISALLOW_COPY_AND_ASSIGN(AwPermissionClient);
 };
 
 }  // namespace android_webview
 
 #endif  // ANDROID_WEBVIEW_RENDERER_AW_PERMISSION_CLIENT_H_