Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1383043002: Stop defensively copying AST structures before resolution (Closed)

Created:
5 years, 2 months ago by Brian Wilkerson
Modified:
5 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop defensively copying AST structures before resolution R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/66a122a9db982574097a2003107f06a9f8c60702

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -12 lines) Patch
M pkg/analysis_server/test/analysis/notification_implemented_test.dart View 3 chunks +9 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/driver.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/inputs.dart View 8 chunks +33 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/task/model.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/task/model.dart View 7 chunks +24 lines, -3 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 2 months ago (2015-10-02 16:16:52 UTC) #2
scheglov
LGTM
5 years, 2 months ago (2015-10-02 16:45:34 UTC) #3
Brian Wilkerson
5 years, 2 months ago (2015-10-02 19:38:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
66a122a9db982574097a2003107f06a9f8c60702 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698