Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Unified Diff: pkg/analysis_server/test/analysis/notification_implemented_test.dart

Issue 1383043002: Stop defensively copying AST structures before resolution (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/analysis/notification_implemented_test.dart
diff --git a/pkg/analysis_server/test/analysis/notification_implemented_test.dart b/pkg/analysis_server/test/analysis/notification_implemented_test.dart
index 5898daf4ee5ca4d14e36c04db9ec10df9928ff9f..fc72b72d566babe7ebf6e0551a59cea4fa1f69f1 100644
--- a/pkg/analysis_server/test/analysis/notification_implemented_test.dart
+++ b/pkg/analysis_server/test/analysis/notification_implemented_test.dart
@@ -37,6 +37,9 @@ class AnalysisNotificationImplementedTest extends AbstractAnalysisTest {
if (length == -1) {
length = findIdentifierLength(search);
}
+ if (implementedClasses == null) {
+ fail('No notification of impemented classes was received');
+ }
for (ImplementedClass clazz in implementedClasses) {
if (clazz.offset == offset && clazz.length == length) {
return;
@@ -57,6 +60,9 @@ class AnalysisNotificationImplementedTest extends AbstractAnalysisTest {
if (length == -1) {
length = findIdentifierLength(search);
}
+ if (implementedMembers == null) {
+ fail('No notification of impemented members was received');
+ }
for (ImplementedMember member in implementedMembers) {
if (member.offset == offset && member.length == length) {
return;
@@ -77,6 +83,9 @@ class AnalysisNotificationImplementedTest extends AbstractAnalysisTest {
if (length == -1) {
length = findIdentifierLength(search);
}
+ if (implementedMembers == null) {
+ fail('No notification of impemented members was received');
+ }
for (ImplementedMember member in implementedMembers) {
if (member.offset == offset) {
fail('Unexpected implemented member at $offset'
« no previous file with comments | « no previous file | pkg/analyzer/lib/src/task/dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698