Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(755)

Issue 1383003003: GN: Update documentation for updating the gn binaries (the rolling process). (Closed)

Created:
5 years, 2 months ago by tfarina
Modified:
5 years, 2 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, asanka, tfarina, benjhayden+dwatch_chromium.org, Bons, brettw
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Update documentation for updating the gn binaries (the rolling process). The doc is stale and there is a script to do this now. BUG=None R=dpranke@chromium.org Committed: https://crrev.com/d7e30d88c7b12ac86e7be77e2d6c2fd0207c24f3 Cr-Commit-Position: refs/heads/master@{#352533}

Patch Set 1 #

Total comments: 2

Patch Set 2 : on linux or mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -33 lines) Patch
M tools/gn/docs/update_binaries.md View 1 1 chunk +2 lines, -33 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
tfarina
5 years, 2 months ago (2015-10-05 17:24:22 UTC) #1
Dirk Pranke
lgtm, though arguably it's now silly to have a separate link for one sentence :).
5 years, 2 months ago (2015-10-05 20:15:05 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1383003003/diff/1/tools/gn/docs/update_binaries.md File tools/gn/docs/update_binaries.md (right): https://codereview.chromium.org/1383003003/diff/1/tools/gn/docs/update_binaries.md#newcode3 tools/gn/docs/update_binaries.md:3: Any committer should be able to do a roll ...
5 years, 2 months ago (2015-10-05 20:15:48 UTC) #3
tfarina
https://codereview.chromium.org/1383003003/diff/1/tools/gn/docs/update_binaries.md File tools/gn/docs/update_binaries.md (right): https://codereview.chromium.org/1383003003/diff/1/tools/gn/docs/update_binaries.md#newcode3 tools/gn/docs/update_binaries.md:3: Any committer should be able to do a roll ...
5 years, 2 months ago (2015-10-06 03:56:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1383003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1383003003/20001
5 years, 2 months ago (2015-10-06 03:56:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-06 04:16:21 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 04:17:27 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d7e30d88c7b12ac86e7be77e2d6c2fd0207c24f3
Cr-Commit-Position: refs/heads/master@{#352533}

Powered by Google App Engine
This is Rietveld 408576698