Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: tools/gn/docs/update_binaries.md

Issue 1383003003: GN: Update documentation for updating the gn binaries (the rolling process). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: on linux or mac Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/docs/update_binaries.md
diff --git a/tools/gn/docs/update_binaries.md b/tools/gn/docs/update_binaries.md
index 2ef502e191628500d7fca71ff697caf2bb1373be..738da3c020af5939b37196b919c39cd3e6f2c2cf 100644
--- a/tools/gn/docs/update_binaries.md
+++ b/tools/gn/docs/update_binaries.md
@@ -1,35 +1,4 @@
# How to update the [GN binaries](gn.md) that Chromium uses.
-## Prerequisites
-
-You'll need a checkout of Chromium, and commit access to the
-`buildtools/` repo. Check with scottmg, thakis, brettw, dpranke, or a
-member of chrome-infra to get access to that repo.
-
-## Instructions
-
-_Hopefully there will be a script that does this all for you shortly._
-
- 1. cd to your Chromium checkout.
- 2. Create a whitespace change in DEPS and upload it to create a "dummy" CL
- 3. Run the following commands:
- 1. git-cl try -b linux\_chromium\_gn\_upload\_x86
- -b linux\_chromium\_gn\_upload\_x64
- -r $GIT\_REVISION\_YOU\_WANT\_TO\_BUILD
- 2. git-cl try -b mac\_chromium\_gn\_upload
- -r $GIT\_REVISION\_YOU\_WANT\_TO\_BUILD
- 3. git-cl try -b win8\_chromium\_gn\_upload
- -r $GIT\_REVISION\_YOU\_WANT\_TO\_BUILD
- 4. Wait for the try jobs to finish.
- 5. If they all ran successfully, copy the digests from the tryjob build
- log output into `src/buildtools/{mac,linux32,linux64}gn.sha1` and
- `src/buildtools/win/gn.exe.sha1` as appropriate.
- 6. Upload a buildtools CL with the updated digests and get it reviewed
- and committed. Make sure you note the revision of GN that you built
- against in the commit message.
- 7. Go back to your "dummy" CL w/ the change to the DEPS file in src/
- and update the buildtools revision to your newly-committed
- buildtools change.
- 8. Get that reviewed and landed in Chromium. Make sure you note the
- revision of GN that you built against in the commit message, along
- with the revision of buildtools that you're rolling to.
+Any committer should be able to do a roll by running //tools/gn/bin/roll_gn.py
+on linux or mac.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698