Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 1382993004: presubmit: unblacklist third_party/WebKit (Closed)

Created:
5 years, 2 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 2 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org, Dirk Pranke
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

presubmit: unblacklist third_party/WebKit The current DEFAULT_BLACKLIST in presubmit_support blacklists by default third_party/.* in every repo. This requires an adjustement after the blink merge, as it causing all the blink presubmits to become noops. BUG=539768 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=297030

Patch Set 1 #

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M presubmit_support.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Primiano Tucci (use gerrit)
5 years, 2 months ago (2015-10-06 08:25:16 UTC) #2
tandrii_google
lgtm though, is this list still supposed to be here? Should we move most of ...
5 years, 2 months ago (2015-10-06 09:22:11 UTC) #4
Primiano Tucci (use gerrit)
On 2015/10/06 09:22:11, tandrii_google wrote: > lgtm > > though, is this list still supposed ...
5 years, 2 months ago (2015-10-06 09:30:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382993004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382993004/20001
5 years, 2 months ago (2015-10-06 09:30:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: depot_tools_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/depot_tools_presubmit/builds/217)
5 years, 2 months ago (2015-10-06 09:35:15 UTC) #9
tandrii(chromium)
On 2015/10/06 09:30:50, Primiano Tucci wrote: > On 2015/10/06 09:22:11, tandrii_google wrote: > > lgtm ...
5 years, 2 months ago (2015-10-06 10:46:56 UTC) #10
tandrii(chromium)
Ah, i gave lgtm with wrong account before. But this one is the owner :)
5 years, 2 months ago (2015-10-06 10:48:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1382993004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1382993004/20001
5 years, 2 months ago (2015-10-06 10:48:19 UTC) #13
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 10:50:14 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=297030

Powered by Google App Engine
This is Rietveld 408576698